Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 print in doctests #23551

Closed
vbraun opened this issue Jul 30, 2017 · 12 comments
Closed

Python 3 print in doctests #23551

vbraun opened this issue Jul 30, 2017 · 12 comments
Labels
c: doctest framework p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@vbraun
Copy link
Member

vbraun commented Jul 30, 2017

Make the deprecated print statement a SyntaxError in doctests (and only doctests)

CC: @fchapoton @jdemeyer

Component: doctest framework

Author: Volker Braun

Branch/Commit: ef399c4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23551
@vbraun vbraun added this to the sage-8.1 milestone Jul 30, 2017
@vbraun
Copy link
Member Author

vbraun commented Jul 30, 2017

Branch: u/vbraun/python_3_print_in_doctests

@vbraun

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member Author

vbraun commented Jul 30, 2017

New commits:

f640131Enable print_function in doctests

@vbraun
Copy link
Member Author

vbraun commented Jul 30, 2017

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Jul 30, 2017

Commit: f640131

@tscrim
Copy link
Collaborator

tscrim commented Jul 30, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 30, 2017

comment:4

This will help prevent Python3 incompatible changes. +1

However, I think we should add a test with appropriate documentation that we enforce Python3-style print() in doctests and fail on Python2-style print.

@fchapoton
Copy link
Contributor

Changed commit from f640131 to ef399c4

@fchapoton
Copy link
Contributor

comment:5

done, please review

New commits:

fb09ba9Merge branch 'u/vbraun/python_3_print_in_doctests' in 8.1.b1
ef399c4trac 23551 adding explanation and doctest in the developer documentation

@fchapoton
Copy link
Contributor

Changed branch from u/vbraun/python_3_print_in_doctests to public/23551

@vbraun
Copy link
Member Author

vbraun commented Aug 6, 2017

comment:6

Thanks!

@vbraun
Copy link
Member Author

vbraun commented Aug 11, 2017

Changed branch from public/23551 to ef399c4

@vbraun vbraun closed this as completed in cc6f721 Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton