Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometric Frobenius is broken #23575

Closed
roed314 opened this issue Aug 2, 2017 · 12 comments
Closed

Geometric Frobenius is broken #23575

roed314 opened this issue Aug 2, 2017 · 12 comments
Labels
c: padics p: major / 3 t: bug
Milestone
sage-9.7

Comments

@roed314
Copy link
Contributor

roed314 commented Aug 2, 2017

#12657 introduced an error in the computation of the geometric Frobenius, uncaught since there are no doctests for geometric Frobenius.

The dependency on #14825 comes from resolving a merge conflict there.

Depends on #14825

Component: padics

Keywords: padicIMA

Author: Xavier Caruso

Branch/Commit: 48c3e10

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23575
@roed314 roed314 added this to the sage-8.1 milestone Aug 2, 2017
@kedlaya
Copy link
Sponsor Contributor

kedlaya commented Aug 8, 2017

comment:1

Would it be possible to add an example to the ticket illustrating the error?

@xcaruso
Copy link
Contributor

xcaruso commented May 23, 2018

comment:2

ping?

@roed314
Copy link
Contributor Author

roed314 commented Jul 22, 2018

Changed keywords from none to padicIMA

@xcaruso
Copy link
Contributor

xcaruso commented Jun 2, 2022

Branch: u/caruso/geometric_frobenius

@xcaruso
Copy link
Contributor

xcaruso commented Jun 2, 2022

Changed branch from u/caruso/geometric_frobenius to none

@xcaruso
Copy link
Contributor

xcaruso commented Jun 2, 2022

Branch: u/caruso/geometric_frobenius

@xcaruso
Copy link
Contributor

xcaruso commented Jun 2, 2022

New commits:

48c3e10fix geometric Frobenius

@xcaruso
Copy link
Contributor

xcaruso commented Jun 2, 2022

Author: Xavier Caruso

@xcaruso
Copy link
Contributor

xcaruso commented Jun 2, 2022

Commit: 48c3e10

@roed314
Copy link
Contributor Author

roed314 commented Jun 2, 2022

comment:8

Looks good to me once tests pass.

@roed314
Copy link
Contributor Author

roed314 commented Jun 2, 2022

Reviewer: David Roe

@fchapoton fchapoton modified the milestones: sage-8.1, sage-9.7 Jun 3, 2022
@vbraun
Copy link
Member

vbraun commented Jun 12, 2022

Changed branch from u/caruso/geometric_frobenius to 48c3e10

@vbraun vbraun closed this as completed in da5e1ac Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: padics p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
5 participants
@roed314 @vbraun @kedlaya @fchapoton @xcaruso