Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some abstract methods to Laurent polynomials base class #23606

Closed
jdemeyer opened this issue Aug 9, 2017 · 8 comments
Closed

Add some abstract methods to Laurent polynomials base class #23606

jdemeyer opened this issue Aug 9, 2017 · 8 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Aug 9, 2017

Rename LaurentPolynomial_generic to LaurentPolynomial (it's not a "generic" implementation, it's an abstract base class) and put some abstract methods there, like cpdef _add_.

CC: @roed314

Component: basic arithmetic

Author: Jeroen Demeyer

Branch/Commit: b0cee8a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23606

@jdemeyer jdemeyer added this to the sage-8.1 milestone Aug 9, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Aug 9, 2017

@jdemeyer
Copy link
Author

jdemeyer commented Aug 9, 2017

Commit: b0cee8a

@jdemeyer
Copy link
Author

jdemeyer commented Aug 9, 2017

New commits:

b0cee8aAdd some abstract methods to Laurent polynomials base class

@tscrim
Copy link
Collaborator

tscrim commented Aug 9, 2017

comment:3

Should we worry about old pickles? Specifically, should we add a register_unpickle_override?

@jdemeyer
Copy link
Author

jdemeyer commented Aug 9, 2017

comment:4

Replying to @tscrim:

Should we worry about old pickles?

I don't think so because

  1. There shouldn't exist objects of type LaurentPolynomial_generic in the first place, only of subclasses.

  2. It's a Cython class so pickling probably won't work anyway.

@tscrim
Copy link
Collaborator

tscrim commented Aug 9, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 9, 2017

comment:5

Alright. Positive review.

@vbraun
Copy link
Member

vbraun commented Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants