Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve calculus intro page #23655

Closed
rwst opened this issue Aug 20, 2017 · 26 comments
Closed

Improve calculus intro page #23655

rwst opened this issue Aug 20, 2017 · 26 comments

Comments

@rwst
Copy link

rwst commented Aug 20, 2017

The calculus intro reachable from the refman main page just is an unordered list of links. Moreover it lacks a few necessary sentences for the beginner.

Component: documentation

Keywords: days88

Author: Ralf Stephan

Branch/Commit: 80ceb09

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23655

@rwst rwst added this to the sage-8.1 milestone Aug 20, 2017
@rwst
Copy link
Author

rwst commented Aug 20, 2017

Branch: u/rws/23655

@rwst
Copy link
Author

rwst commented Aug 20, 2017

New commits:

00f118223655: Improve calculus intro page

@rwst
Copy link
Author

rwst commented Aug 20, 2017

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Aug 20, 2017

Commit: 00f1182

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:4

It all worked out with sage -docbuild reference but make doc fails miserably. Why?

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

Changed commit from 00f1182 to 45614fa

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

Changed branch from u/rws/23655 to u/tscrim/23655

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

comment:5

So I am pretty sure why it is not working is because the files are not known to sphinx because it is looking for files in a .. toctree::. So I mimicked what asymptotics do; give this a try and let me know if it works and you like it.


New commits:

45614faTrying to get doc to build.

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

Changed keywords from none to days88

@rwst
Copy link
Author

rwst commented Aug 21, 2017

Changed branch from u/tscrim/23655 to u/rws/23655-1

@rwst
Copy link
Author

rwst commented Aug 21, 2017

Changed commit from 45614fa to ee18149

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:7

Argh simultaneously.


New commits:

ee1814923655: Improve calculus intro page

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:8

OK, I think we'll take your solution.

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

Changed branch from u/rws/23655-1 to u/tscrim/23655

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

comment:9

Lol Well, I think mine is a little better in terms of layout, but I like your hidden toctree. Can you make a hybrid branch?

(Addendum: sorry, I didn't mean to change the branch.)


New commits:

00f118223655: Improve calculus intro page
45614faTrying to get doc to build.

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

Changed commit from ee18149 to 45614fa

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:10

I'll do the hybrid.

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

comment:11

Thank you.

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:12

You should really check once more if it builds for you after a make doc-clean because here it doesn't and with the patchbot it won't. This is really peculiar because in prep/Quickstart... there are links to a level higher that work. It would be interesting if it builds for you always.

@rwst
Copy link
Author

rwst commented Aug 21, 2017

Changed branch from u/tscrim/23655 to public/23655

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:14

This will compile for me, so let's make it the branch.


New commits:

80ceb0923655: make toctree hidden and remove broken link

@rwst
Copy link
Author

rwst commented Aug 21, 2017

Changed commit from 45614fa to 80ceb09

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2017

comment:15

Thank you.

@rwst
Copy link
Author

rwst commented Aug 21, 2017

comment:16

Thanks for the review.

@vbraun
Copy link
Member

vbraun commented Aug 26, 2017

Changed branch from public/23655 to 80ceb09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants