Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: some work on cmp in heegner #23676

Closed
fchapoton opened this issue Aug 22, 2017 · 12 comments
Closed

py3: some work on cmp in heegner #23676

fchapoton opened this issue Aug 22, 2017 · 12 comments

Comments

@fchapoton
Copy link
Contributor

step to python3

CC: @kevindilks @tscrim @saliola

Component: python3

Keywords: days88, IMA coding sprints

Author: Frédéric Chapoton

Branch/Commit: fc84daf

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23676

@fchapoton fchapoton added this to the sage-8.1 milestone Aug 22, 2017
@fchapoton
Copy link
Contributor Author

Commit: fc84daf

@fchapoton
Copy link
Contributor Author

New commits:

fc84dafpy3: some work on cmp in heegner.py

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23676

@kevindilks
Copy link
Mannequin

kevindilks mannequin commented Aug 22, 2017

Changed keywords from none to days88

@kevindilks
Copy link
Mannequin

kevindilks mannequin commented Aug 22, 2017

comment:2

There's a few people at Sage Days 88 who may be interested in figuring out more about what making fixed to ensure Python3 compatibility entails.

@fchapoton
Copy link
Contributor Author

comment:3

I am not sure to understand what you mean exactly.

  1. if you want to see the current state of affairs, you can use the branch "public/python3-experiment-v1" together with "export SAGE_PYTHON3=yes". Of course, this implies a very long compilation.

  2. see my last message here : https://groups.google.com/forum/#!searchin/sage-devel/python3%7Csort:relevance/sage-devel/TOrSXDutNvA/OnGDFvx6AgAJ

So if anybody wants to help, tackling the hard #22875 would be a way. Another one would be to convert all the pexpect interfaces to use unicode. A third one would be to update cypari2 (#23518), etc, etc

EDIT:

or handle #23648

or convert "src/sage/combinat/words/abstract_word.py" to use richcmp instead of cmp()

@kevindilks
Copy link
Mannequin

kevindilks mannequin commented Aug 22, 2017

comment:4

I don't follow sage-devel, so I didn't know what the state of things was, I just have generically heard 'we need to convert things to Python 3'.

Most of this seems beyond what I'm capable of, but I might try and look at abstract_word.py and see if I can correct things using this ticket as a model.

@fchapoton
Copy link
Contributor Author

comment:5

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Aug 23, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 23, 2017

Changed keywords from days88 to days88, IMA coding sprints

@tscrim
Copy link
Collaborator

tscrim commented Aug 23, 2017

comment:6

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 4, 2017

Changed branch from u/chapoton/23676 to fc84daf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants