Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some_elements() of products more interesting #23686

Open
saraedum opened this issue Aug 23, 2017 · 2 comments
Open

Make some_elements() of products more interesting #23686

saraedum opened this issue Aug 23, 2017 · 2 comments

Comments

@saraedum
Copy link
Member

A common pattern used in doctests is

S = tester.some_elements()
M = cartesian product of S
for x,y in tester.some_elements(M):
    check things

Sometimes we need to set max_runs to make this product not get too big (especially if it is more than two copies of S involved.)

The current implementation of some_elemnts() then just takes the first few elements of the product. This is unfortunate because it means that we are not testing an interesting subset of the product.

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/23686

@tscrim
Copy link
Collaborator

tscrim commented Aug 23, 2017

comment:1

You want some magic code that can tell what objects are interesting. Instead you should just actually better use some_elements. I think the goal of this is impossible and there are tangible, good solutions. Thus we should close this as invalid.

@roed314
Copy link
Contributor

roed314 commented Aug 28, 2017

comment:2

Travis and I had a discussion in person, resulting in #23724. I think we should return to this discussion after that ticket is resolved.

@mkoeppe mkoeppe removed this from the sage-8.1 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants