Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in greedy method for cluster seed #23688

Closed
sagetrac-llpku mannequin opened this issue Aug 23, 2017 · 6 comments
Closed

Typo in greedy method for cluster seed #23688

sagetrac-llpku mannequin opened this issue Aug 23, 2017 · 6 comments

Comments

@sagetrac-llpku
Copy link
Mannequin

sagetrac-llpku mannequin commented Aug 23, 2017

There's a typo in the greedy function; the following should be the same.

sage: S = ClusterSeed(Matrix([[0,1],[-4,0]])); S
A seed for a cluster algebra of rank 2
sage: S.greedy(1,2)
(x1^4 + x0^2 + 2*x0 + 1)/(x0*x1^2)
sage: S.greedy(1,2,'by_combinatorics')
(x0*x1^4 + x1^4 + x0^2 + 2*x0 + 1)/(x0*x1^2)

Component: combinatorics

Keywords: cluster algebras, days88

Author: Li Li

Branch/Commit: c65e4ab

Reviewer: Gregg Musiker

Issue created by migration from https://trac.sagemath.org/ticket/23688

@sagetrac-llpku sagetrac-llpku mannequin added this to the sage-8.1 milestone Aug 23, 2017
@roed314
Copy link
Contributor

roed314 commented Aug 23, 2017

@roed314
Copy link
Contributor

roed314 commented Aug 23, 2017

New commits:

c65e4abFix typo in cluster_seed.py

@roed314
Copy link
Contributor

roed314 commented Aug 23, 2017

Commit: c65e4ab

@roed314
Copy link
Contributor

roed314 commented Aug 23, 2017

Reviewer: Gregg Musiker

@roed314
Copy link
Contributor

roed314 commented Aug 23, 2017

comment:4

Note: this was a demo ticket at Sage Days 88, which is why I made all the changes.

@vbraun
Copy link
Member

vbraun commented Sep 4, 2017

Changed branch from u/roed/typo_in_greedy_method_for_cluster_seed to c65e4ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants