New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctests from Judson's Abstract Algebra textbook #23705
Comments
Changed branch from /u/rbeezer/t/23705/doctest-abstract-algebra to u/rbeezer/t/23705/doctest-abstract-algebra |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed keywords from none to sd88 |
comment:6
A small patchbot complaint (I have none): the print statements in the documentation should now use python 3 syntax. The following is (almost) wrong
I agree that this is not tested but the patchbot is not smart enough. |
Reviewer: Vincent Delecroix |
Changed keywords from sd88 to days88 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Thanks, Vincent. I caught 4 other old-style print statements, but missed the untested one. Thanhks very much for looking at this one. |
comment:10
Now patchbot is very happy ;-) |
comment:11
Merci, Vincent. The patchbot is working much better than it used to! Nice to meet you this past week at SD88. |
Changed branch from u/rbeezer/t/23705/doctest-abstract-algebra to |
comment:13
Hi, This is giving doctest failures at https://patchbot.sagemath.org/log/23927/Ubuntu/14.04/i686/3.13.0-95-generic/arando/2017-09-25%2021:41:12?short the answers seem to be mathematically correct, and the failures seem to stem from output of nondeterministic algorithms being tested. |
Changed commit from |
comment:14
This is now #23930 |
comment:15
Also trouble in #23544. |
comment:16
Just a question: I noticed that the tests are written as |
comment:17
(I tried to reply by email while traveling - I guess that didn't work.) There was no particular reason for using |
Add roughly 700 doctests from the examples in this undergraduate text. Total CPU time is roughly 7.5 seconds on an ordinary laptop.
Component: doctest coverage
Keywords: days88
Author: Rob Beezer
Branch:
5e9dff8
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/23705
The text was updated successfully, but these errors were encountered: