Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy of libgap object is broken #23721

Closed
videlec opened this issue Aug 25, 2017 · 11 comments
Closed

copy of libgap object is broken #23721

videlec opened this issue Aug 25, 2017 · 11 comments
Labels
c: interfaces p: major / 3 t: bug
Milestone
sage-8.1

Comments

@videlec
Copy link
Contributor

videlec commented Aug 25, 2017 

sage: l = libgap([0,1])
sage: l
sage: copy(l)
NULL

Component: interfaces

Author: Vincent Delecroix

Branch/Commit: a087066

Reviewer: Aly Deines

Issue created by migration from https://trac.sagemath.org/ticket/23721
@videlec videlec added this to the sage-8.1 milestone Aug 25, 2017
@videlec
Copy link
Contributor Author

videlec commented Aug 25, 2017

Commit: 3060ae6

@videlec
Copy link
Contributor Author

videlec commented Aug 25, 2017

New commits:

457d2fb23704: getitem/setitem for libgap elements
4dc210b23704: forgot to set j appropriately!
c3241d623704: "multi-indices "multi indices" "multiindices"
3060ae623721: fix `__copy__` on GapElement

@videlec
Copy link
Contributor Author

videlec commented Aug 25, 2017

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Aug 25, 2017

Branch: u/vdelecroix/23721

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7cfd28523721: fix `__copy__` on GapElement

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2017

Changed commit from 3060ae6 to 7cfd285

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a08706623721: __copy__/__deepcopy__ on GapElement

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2017

Changed commit from 7cfd285 to a087066

@adeines
Copy link
Mannequin

adeines mannequin commented Aug 26, 2017

Reviewer: Aly Deines

@adeines
Copy link
Mannequin

adeines mannequin commented Aug 26, 2017

comment:4

Looks good.

@vbraun
Copy link
Member

vbraun commented Sep 4, 2017

Changed branch from u/vdelecroix/23721 to a087066

@vbraun vbraun closed this as completed in d954c82 Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
2 participants
@vbraun @videlec