Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SAGE_ROOT/build to SAGE_ROOT/sage-distro, SAGE_ROOT/src to SAGE_ROOT/sagelib #23747

Closed
mkoeppe opened this issue Aug 30, 2017 · 5 comments
Closed

Rename SAGE_ROOT/build to SAGE_ROOT/sage-distro, SAGE_ROOT/src to SAGE_ROOT/sagelib #23747

mkoeppe opened this issue Aug 30, 2017 · 5 comments
Labels
c: build r: invalid t: enhancement

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 30, 2017

I propose to rename build to sage-distro and src to sagelib (cf. #21507). This is to clarify the purpose of these directories.

Too many things are called src and build, even more with #21469 (VPATH), it's getting confusing.

I'm hoping git is smart enough to handle such renames when we merge tickets, but I am not sure.

CC: @vbraun @jdemeyer @tscrim @slel

Component: build

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/23747
@mkoeppe mkoeppe added this to the sage-8.2 milestone Aug 30, 2017
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 10, 2021

Dependencies: #31577

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 10, 2021

comment:1

Superseded by #31577

@mkoeppe mkoeppe removed this from the sage-8.2 milestone Apr 10, 2021
@slel
Copy link
Member

slel commented Aug 19, 2021

comment:2

Let us close this now that #31577 is in.

@slel
Copy link
Member

slel commented Aug 19, 2021

Changed dependencies from #31577 to none

@slel
Copy link
Member

slel commented Aug 19, 2021

Reviewer: Samuel Lelièvre

@mkoeppe mkoeppe closed this as completed Aug 26, 2021
@mkoeppe mkoeppe mentioned this issue Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build r: invalid t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slel @mkoeppe