Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _richcmp_ in morphism.pyx #23750

Closed
jdemeyer opened this issue Aug 30, 2017 · 9 comments
Closed

Fix _richcmp_ in morphism.pyx #23750

jdemeyer opened this issue Aug 30, 2017 · 9 comments

Comments

@jdemeyer
Copy link

#23485 mistakenly used def _richcmp_ instead of cpdef _richmp_.

CC: @saraedum @roed314

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: f1c779f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23750

@jdemeyer jdemeyer added this to the sage-8.1 milestone Aug 30, 2017
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

f1c779fFix `_richcmp_` signature

@jdemeyer
Copy link
Author

Commit: f1c779f

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@tscrim
Copy link
Collaborator

tscrim commented Aug 30, 2017

comment:3

I believe these also need to be declared in the pxd file, correct?

@jdemeyer
Copy link
Author

comment:4

Replying to @tscrim:

I believe these also need to be declared in the pxd file, correct?

No because it's already declared in element.pxd

@tscrim
Copy link
Collaborator

tscrim commented Aug 30, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 30, 2017

comment:5

Okay. LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 4, 2017

Changed branch from u/jdemeyer/fix__richcmp__in_morphism_pyx to f1c779f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants