Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 octave test failures with -optional=sage,external #23768

Closed
videlec opened this issue Aug 31, 2017 · 6 comments
Closed

4 octave test failures with -optional=sage,external #23768

videlec opened this issue Aug 31, 2017 · 6 comments

Comments

@videlec
Copy link
Contributor

videlec commented Aug 31, 2017

sage -t --warn-long 73.4 src/doc/en/constructions/linear_algebra.rst
**********************************************************************
File "src/doc/en/constructions/linear_algebra.rst", line 460, in doc.en.constructions.linear_algebra
Failed example:
    octave.solve_linear_system(A,b)    # optional - octave
Expected:
    [-0.33333299999999999, 0.66666700000000001, 0]
Got:
    [-0.333333, 0.666667, 0]
**********************************************************************
1 item had failures:
   1 of 115 in doc.en.constructions.linear_algebra
    [93 tests, 1 failure, 4.46 s]
sage -t --warn-long 73.4 src/doc/en/developer/coding_in_other.rst
**********************************************************************
File "src/doc/en/developer/coding_in_other.rst", line 705, in doc.en.developer.coding_in_other.solve_linear_system
Failed example:
    octave.solve_linear_system(A,b)    # optional - octave
Expected:
    [-0.33333299999999999, 0.66666700000000001, -3.5236600000000002e-18]
Got:
    [-0.333333, 0.666667, 0]
**********************************************************************
1 item had failures:
   1 of   6 in doc.en.developer.coding_in_other.solve_linear_system
    [41 tests, 1 failure, 1.35 s]
sage -t --warn-long 73.4 src/sage/interfaces/octave.py
**********************************************************************
File "src/sage/interfaces/octave.py", line 218, in sage.interfaces.octave.Octave.set_seed
Failed example:
    [o.rand() for i in range(5)] # optional - octave
Expected:
    [ 0.134364,  0.847434,  0.763775,  0.255069,  0.495435]
Got:
    [0.134364, 0.847434, 0.763775, 0.255069, 0.495435]
**********************************************************************
File "src/sage/interfaces/octave.py", line 650, in sage.interfaces.octave.OctaveElement.__bool__
Failed example:
    bool(octave('[]'))                # optional - octave
Expected:
    False
Got:
    True
**********************************************************************
2 items had failures:
   1 of   4 in sage.interfaces.octave.Octave.set_seed
   1 of   8 in sage.interfaces.octave.OctaveElement.__bool__
    [133 tests, 2 failures, 3.13 s]

Component: interfaces

Author: Frédéric Chapoton

Branch/Commit: 31a5f1d

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/23768

@videlec videlec added this to the sage-8.1 milestone Aug 31, 2017
@fchapoton
Copy link
Contributor

Branch: u/chapoton/23768

@fchapoton
Copy link
Contributor

comment:1

Tested and corrected with octave 4.0.0

I do not see the failures in src/sage/interfaces/octave.py.


New commits:

31a5f1dfix some octave optional doctests

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Commit: 31a5f1d

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@vbraun
Copy link
Member

vbraun commented May 22, 2018

Changed branch from u/chapoton/23768 to 31a5f1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants