Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pynac build with Python 3 #23791

Closed
embray opened this issue Sep 6, 2017 · 2 comments
Closed

Make pynac build with Python 3 #23791

embray opened this issue Sep 6, 2017 · 2 comments

Comments

@embray
Copy link
Contributor

embray commented Sep 6, 2017

As discussed in the past (e.g. #15530) pynac does not work, at least at one time with Python 3. #18537 apparently at least got it to build with Python 3 headers, but nothing working beyond that. When pynac is built in Sage, even with SAGE_PYTHON3=yes, it builds pynac against Python 2.

This breaks horribly more or less as soon as pynac is invoked in Sage with Python 3, because the way libpynac works it assumes it's being loaded into an already initialized Python interpreter--well we do have a Python 3 interpreter running, but the Python 2 interpreter it's trying to use is not initialized. And in any case I don't want to think about what will happen if we try to pass PyObject *s between different Python interpreters. Obviously pynac should be made to work with Python 3. Somehow I couldn't find an existing ticket specifically for this though.

It looks like some work has already done to make pynac work with Python 3, but Sage doesn't seem to be using it properly yet.

CC: @kiwifb @fchapoton

Component: python3

Issue created by migration from https://trac.sagemath.org/ticket/23791

@embray embray added this to the sage-8.1 milestone Sep 6, 2017
@embray
Copy link
Contributor Author

embray commented Sep 6, 2017

comment:1

Oh, I think this was actually fixed by #23325. Confirming...

@embray
Copy link
Contributor Author

embray commented Sep 6, 2017

comment:2

Yes, #23325 fixed it--libpynac links with libpython3.6 now. I didn't see that ticket since it was closed, but not really "merged" into the "develop" branch. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant