Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: Fix import time assertion error from ntl_ZZ.__init__ #23792

Closed
embray opened this issue Sep 6, 2017 · 5 comments
Closed

python3: Fix import time assertion error from ntl_ZZ.__init__ #23792

embray opened this issue Sep 6, 2017 · 5 comments
Labels
c: python3 p: major / 3 t: bug
Milestone
sage-8.1

Comments

@embray
Copy link
Contributor

embray commented Sep 6, 2017

This fixes a crash that occurs sometimes during import of sage.libs.ntl.ntl_ZZ, where ntl_ZZ is passed a random int between 0 and 2!^64. This sometimes caused an assertion error due to and unhandled overflow error that could occur by trying to stuff a PyLong into a machine signed long.

CC: @fchapoton

Component: python3

Author: Erik Bray

Branch/Commit: ecb2346

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/23792
@embray embray added this to the sage-8.1 milestone Sep 6, 2017
@embray

This comment has been minimized.

Sign in to view
@embray
Copy link
Contributor Author

embray commented Sep 6, 2017

comment:1

I suspect there are probably other cases like this one that I can try to suss out, either as part of this ticket, or just one at a time as we find them...

@fchapoton
Copy link
Contributor

comment:3

ok, looks good.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Sep 11, 2017

Changed branch from u/embray/python3/ntl_ZZ_long to ecb2346

@vbraun vbraun closed this as completed in b435fee Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@embray @vbraun @fchapoton