New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 build error: unicode problem in pip_installed_packages() #23822
Comments
New commits:
|
Commit: |
Branch: u/mderickx/23822 |
Author: Maarten Derickx |
comment:3
ok, let it be |
Reviewer: Frédéric Chapoton |
comment:4
Do you need the
? |
comment:5
In python 2 it is not needed but good praxis. In python 3 it is needed since stdout is a bytestring before decoding and the json library only takes unicode strings and not bytestrings as input. |
comment:6
When I was looking at #23876, I came across this bug and didn't use Okay, I checked the Python documentation. I agree that Edit: this behavior of |
comment:7
I could have sworn that I only added the decode() because it was failing otherwise. But sage was already on 3.6 when I wrote this. I dont think either solution is clearly better then the other. But the one with a decode already has positive review so I propose to leave it as is. |
Changed branch from u/mderickx/23822 to |
The python 3 build was broken by #23615 because of incorrect unicode usage causing the building of sage failing in the following way
Component: python3
Author: Maarten Derickx
Branch/Commit:
f3e5282
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/23822
The text was updated successfully, but these errors were encountered: