Add SBox Instance: DBlock cipher

[pfasante]

The list of sboxes does not contain the sbox of the "DBlock" block cipher, see https://link.springer.com/article/10.1007/s11432-014-5219-0.

Depends on #22988

CC: leo.perrin@inria.fr

Component: cryptography

Keywords: sbox

Author: Friedrich Wiemer

Branch/Commit: 6664059

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23830

[pfasante]

Dependencies: 22988

[pfasante]

Branch: u/asante/add_sbox_instance__dblock_cipher

[pfasante]

Last 10 new commits:

09e1c4a	iteritems not py3 compatible -> items
5fd496d	Merge branch 'develop' into t/22988/add_sbox_instances
c223d51	Merge branch 'develop' into t/22988/add_sbox_instances
43edbb8	fixed broken PRESENT reference
dfbd71d	fix merge conflict
6b8e8b1	the qarma block cipher actually defines three sboxes, one was missing
9b5786a	Merge branch 'develop' into t/22988/add_sbox_instances
9515fe6	fixes patchbot errors
31aa2db	Merge branch 'u/asante/add_sbox_instances' of git://trac.sagemath.org/sage into t/22988/add_sbox_instances
6664059	added sbox instance for DBlock block cipher

[pfasante]

Commit: 6664059

[pfasante]

comment:5

I'm not sure, if merging the fixed branch from #22988 is correct.
Maybe waiting for the changes to show up in the main branch and then adding the Sbox instance is a better way?

[roed314]

comment:6

For the author, you should have your actual name rather than trac username.

[roed314]

comment:7

Other than that, this looks fine.

A more general issue with the list of sboxes: is there any good way to check whether these sboxes are correct? It would be really easy to have a typo in the definition that nobody caught.

[roed314]

comment:8

Also, when you list dependencies, use a # symbol so that it creates a link to the other ticket.

[roed314]

Reviewer: David Roe

[roed314]

Changed dependencies from 22988 to #22988

[roed314]

Changed author from asante to Friedrich Wiemer

[vbraun]

Changed branch from u/asante/add_sbox_instance__dblock_cipher to 6664059