Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hash of multivariate Laurent polynomials #23864

Closed
videlec opened this issue Sep 15, 2017 · 9 comments
Closed

fix hash of multivariate Laurent polynomials #23864

videlec opened this issue Sep 15, 2017 · 9 comments

Comments

@videlec
Copy link
Contributor

videlec commented Sep 15, 2017

sage: L.<x,y> = LaurentPolynomialRing(QQ)
sage: hash(L.one())  # this is wrong !
3
sage: hash(L.zero()) # this is even worse!
Traceback (most recent call last):
...
AttributeError: 'NoneType' object has no attribute 'is_constant'

Component: algebra

Keywords: thursdaysbdx

Author: Vincent Delecroix

Branch/Commit: 932ccc1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23864

@videlec videlec added this to the sage-8.1 milestone Sep 15, 2017
@videlec
Copy link
Contributor Author

videlec commented Sep 15, 2017

Commit: 378d286

@videlec
Copy link
Contributor Author

videlec commented Sep 15, 2017

Branch: u/vdelecroix/23864

@videlec
Copy link
Contributor Author

videlec commented Sep 15, 2017

New commits:

378d28623864: fix hash of multivariate laurent polys

@tscrim
Copy link
Collaborator

tscrim commented Sep 15, 2017

comment:2

Trivial thing: could you make this doctest consistent with spacing:

hash(1 - 7* x0 + x1*x2) == hash(L(1 - 7 *x0 + x1*x2))

Once done, you can set a positive review on my behalf.

@tscrim
Copy link
Collaborator

tscrim commented Sep 15, 2017

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 16, 2017

Changed commit from 378d286 to 932ccc1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 16, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

932ccc123864: consistent spacing in doc

@videlec
Copy link
Contributor Author

videlec commented Sep 16, 2017

comment:4

done! Thanks Travis.

@vbraun
Copy link
Member

vbraun commented Sep 18, 2017

Changed branch from u/vdelecroix/23864 to 932ccc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants