allow libgap integers as indices

[videlec]

sage: s = 'abcd'
sage: s[libgap(1)]
Traceback (most recent call last):
...
TypeError: string indices must be integers,
not sage.libs.gap.element.GapElement_Integer

Component: interfaces

Author: Vincent Delecroix

Branch/Commit: a102cf1

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/23878

[videlec]

Branch: u/vdelecroix/23878

[videlec]

New commits:

5bdbbb0

23878: allow libgap integers as indices

[videlec]

Commit: 5bdbbb0

[jdemeyer]

comment:2

I would prefer return int(self) instead of duplicating the __int__ code.

[videlec]

comment:3

Agreed, but it ends up with a lot of indirections... (though one might hope that Cython actually bypass some of them)

[sagetrac-git]

Changed commit from 5bdbbb0 to a102cf1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a102cf1

23878: allow libgap integers as indices

[videlec]

comment:5

done

[jdemeyer]

comment:6

Replying to @videlec:

Agreed, but it ends up with a lot of indirections...

True, but those indirections are not much of an issue since they are in Cython and C.

[jdemeyer]

comment:7

positive_review if it passes tests.

[jdemeyer]

Reviewer: Jeroen Demeyer

[vbraun]

Changed branch from u/vdelecroix/23878 to a102cf1