Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to six 1.11 #23890

Closed
jdemeyer opened this issue Sep 19, 2017 · 11 comments
Closed

Upgrade to six 1.11 #23890

jdemeyer opened this issue Sep 19, 2017 · 11 comments

Comments

@jdemeyer
Copy link

This allows to remove the Sage-specific with_metaclass implementation.

Upstream: https://pypi.python.org/packages/16/d8/bc6316cf98419719bd59c91742194c111b6f2e85abac88e496adefaf7afe/six-1.11.0.tar.gz

CC: @kiwifb

Component: packages: standard

Author: Jeroen Demeyer

Branch: 76e5a88

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/23890

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/upgrade_to_six_1_11

@jdemeyer
Copy link
Author

New commits:

76e5a88Upgrade to six 1.11

@jdemeyer
Copy link
Author

Commit: 76e5a88

@jdemeyer
Copy link
Author

comment:5

Do you have doubts about this ticket?

@kiwifb
Copy link
Member

kiwifb commented Sep 24, 2017

comment:6

No it is more I am keeping an eye on some of these. For my own reasons. For this one I was hoping I was not going to have to make an ebuild for Gentoo, but it looks like I will have to.

Unlike cython, there are changes, and changes that I cannot brush off. I have already taken care of all previous sage versions in sage-on-gentoo so that they wouldn't allow the installation of this version of six.

I will give you a review in the next 24hours.

@kiwifb
Copy link
Member

kiwifb commented Sep 24, 2017

comment:7

Looks good to me.

@kiwifb
Copy link
Member

kiwifb commented Sep 24, 2017

Reviewer: François Bissey

@vbraun
Copy link
Member

vbraun commented Sep 26, 2017

Changed branch from u/jdemeyer/upgrade_to_six_1_11 to 76e5a88

@embray
Copy link
Contributor

embray commented Oct 28, 2018

Changed commit from 76e5a88 to none

@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:9

I don't think you should have removed the workaround code just yet, as now this requires any downstream systems to upgrade to six 1.11. That said, I don't see any reason not to push that anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants