New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to six 1.11 #23890
Comments
This comment has been minimized.
This comment has been minimized.
Branch: u/jdemeyer/upgrade_to_six_1_11 |
New commits:
|
Commit: |
comment:5
Do you have doubts about this ticket? |
comment:6
No it is more I am keeping an eye on some of these. For my own reasons. For this one I was hoping I was not going to have to make an ebuild for Gentoo, but it looks like I will have to. Unlike cython, there are changes, and changes that I cannot brush off. I have already taken care of all previous sage versions in sage-on-gentoo so that they wouldn't allow the installation of this version of I will give you a review in the next 24hours. |
comment:7
Looks good to me. |
Reviewer: François Bissey |
Changed branch from u/jdemeyer/upgrade_to_six_1_11 to |
Changed commit from |
comment:9
I don't think you should have removed the workaround code just yet, as now this requires any downstream systems to upgrade to six 1.11. That said, I don't see any reason not to push that anyways. |
This allows to remove the Sage-specific
with_metaclass
implementation.Upstream: https://pypi.python.org/packages/16/d8/bc6316cf98419719bd59c91742194c111b6f2e85abac88e496adefaf7afe/six-1.11.0.tar.gz
CC: @kiwifb
Component: packages: standard
Author: Jeroen Demeyer
Branch:
76e5a88
Reviewer: François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/23890
The text was updated successfully, but these errors were encountered: