Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assign _element_constructor in combinat/sf #23899

Closed
jdemeyer opened this issue Sep 20, 2017 · 6 comments
Closed

Do not assign _element_constructor in combinat/sf #23899

jdemeyer opened this issue Sep 20, 2017 · 6 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

Component: combinatorics

Author: Jeroen Demeyer

Branch/Commit: 44bc9fb

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23899
@jdemeyer jdemeyer added this to the sage-8.1 milestone Sep 20, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/do_not_assign__element_constructor_in_combinat_sf

@jdemeyer
Copy link
Author

New commits:

44bc9fbDo not assign _element_constructor in combinat/sf

@jdemeyer
Copy link
Author

Commit: 44bc9fb

@tscrim
Copy link
Collaborator

tscrim commented Sep 20, 2017

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 20, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Sep 22, 2017

Changed branch from u/jdemeyer/do_not_assign__element_constructor_in_combinat_sf to 44bc9fb

@vbraun vbraun closed this as completed in 24ce59f Sep 22, 2017
@jdemeyer jdemeyer mentioned this issue Oct 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer