New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set_PythonType_class: don't use custom element_constructor #23900
Labels
Milestone
Comments
Commit: |
New commits:
|
Author: Jeroen Demeyer |
This comment has been minimized.
This comment has been minimized.
comment:4
ok |
Reviewer: Frédéric Chapoton |
Changed branch from u/jdemeyer/set_pythontype_class__don_t_use_custom_element_constructor to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we want to remove the
element_constructor
argument toParent.__init__
, we should fix this:This is easily done by defining an
_element_constructor_
method.This branch also changes "type" to "class" in the documentation and
__repr__
to prepare for Python 3 (which consistently uses "class" in the__repr__
of types).CC: @simon-king-jena
Component: misc
Author: Jeroen Demeyer
Branch/Commit:
e6469c5
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/23900
The text was updated successfully, but these errors were encountered: