Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cases where exception is returned #23918

Closed
jdemeyer opened this issue Sep 22, 2017 · 9 comments
Closed

Fix cases where exception is returned #23918

jdemeyer opened this issue Sep 22, 2017 · 9 comments
Labels
p: major / 3 t: bug
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

Functions normally do not return exceptions, so return NotImplementedError is almost certainly a mistake.

CC: @tscrim

Component: misc

Author: Jeroen Demeyer

Branch/Commit: fdc151d

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23918
@jdemeyer jdemeyer added this to the sage-8.1 milestone Sep 22, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Fix cases where exception is returned instead of raised Fix cases where exception is returned Sep 22, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/fix_cases_where_exception_is_returned_instead_of_raised

@jdemeyer
Copy link
Author

Commit: fdc151d

@jdemeyer
Copy link
Author

New commits:

fdc151dDo not return exceptions by mistake

@fchapoton
Copy link
Contributor

comment:4

positive review if bot gives a green light.

@tscrim
Copy link
Collaborator

tscrim commented Sep 22, 2017

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 22, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 22, 2017

Changed reviewer from Travis Scrimshaw to Frédéric Chapoton, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Sep 24, 2017

Changed branch from u/jdemeyer/fix_cases_where_exception_is_returned_instead_of_raised to fdc151d

@vbraun vbraun closed this as completed in 90fcfd0 Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
4 participants
@vbraun @tscrim @jdemeyer @fchapoton