Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 : some work on __cmp__ and richcmp #23949

Closed
fchapoton opened this issue Oct 1, 2017 · 11 comments
Closed

py3 : some work on __cmp__ and richcmp #23949

fchapoton opened this issue Oct 1, 2017 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@fchapoton
Copy link
Contributor

as a step to py3

CC: @tscrim @jdemeyer @jhpalmieri @kiwifb

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 030d04b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23949
@fchapoton fchapoton added this to the sage-8.1 milestone Oct 1, 2017
@fchapoton
Copy link
Contributor Author

New commits:

130182fsome work on richcmp and `__cmp__` towards python3

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/23949

@fchapoton
Copy link
Contributor Author

Commit: 130182f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

516908dforgotten import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2017

Changed commit from 130182f to 516908d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2017

Changed commit from 516908d to 030d04b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

030d04bsome work on richcmp and `__cmp__` towards python3

@fchapoton
Copy link
Contributor Author

comment:4

green bot, needs review

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2017

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 15, 2017

Changed branch from u/chapoton/23949 to 030d04b

@vbraun vbraun closed this as completed in a5eeff6 Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton