Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterator for hypergeometric motives #23953

Closed
kedlaya opened this issue Oct 1, 2017 · 16 comments
Closed

Iterator for hypergeometric motives #23953

kedlaya opened this issue Oct 1, 2017 · 16 comments

Comments

@kedlaya
Copy link
Sponsor Contributor

kedlaya commented Oct 1, 2017

Ticket #23671 provides the function possible_hypergeometric_data which returns a list of all hypergeometric data with prescribed degree (and optionally weight). It would be better to also provide an iterator, so that one can do a list comprehension to further filter the results without instantiating the entire list.

Depends on #23671

Component: modular forms

Keywords: sd91

Author: Kiran Kedlaya

Branch/Commit: 949a775

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23953

@kedlaya kedlaya added this to the sage-8.1 milestone Oct 1, 2017
@kedlaya
Copy link
Sponsor Contributor Author

kedlaya commented Oct 1, 2017

@kedlaya
Copy link
Sponsor Contributor Author

kedlaya commented Oct 2, 2017

Dependencies: #23671

@kedlaya
Copy link
Sponsor Contributor Author

kedlaya commented Oct 2, 2017

Last 10 new commits:

656112fCorrect description of sign
4179f4bMore minor edits
cc53131Typo fix
3cdb07ctrac 23671 fix wrong syntax for raise
cd7c290Merge branch 'u/chapoton/23671' in 8.1.b6
1d1039ftrac 23671 moving refs to the huge list of refs
12aa8f2trac 23671 better ref to slides
de3f9cbReviewer changes to 23671
0c54a65Add cached_method to hypergeometric motives
a9d4113Implemented iterator for hypergeometric motives

@kedlaya
Copy link
Sponsor Contributor Author

kedlaya commented Oct 2, 2017

Commit: a9d4113

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

d60b78eAdd import of itertools.combinations

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2017

Changed commit from a9d4113 to d60b78e

@roed314
Copy link
Contributor

roed314 commented Oct 2, 2017

Author: Kiran Kedlaya

@roed314
Copy link
Contributor

roed314 commented Oct 2, 2017

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Oct 2, 2017

comment:4

Positive review once tests pass.

@roed314
Copy link
Contributor

roed314 commented Oct 2, 2017

@roed314
Copy link
Contributor

roed314 commented Oct 2, 2017

comment:6

Merged in the changes the remove the tab. The other tests pass, so positive review.


New commits:

778b876removing TAB again
316ab9bMerge branch 't/23671/hypergeometric_motives' into t/23953/iterator_for_hypergeometric_motives

@roed314
Copy link
Contributor

roed314 commented Oct 2, 2017

Changed commit from d60b78e to 316ab9b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 6, 2017

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

fd375d3Merge branch 'u/chapoton/23671' in 8.1.b7
d8c961btrac 23671 care for pdf doc
949a775Merge branch 'u/roed/iterator_for_hypergeometric_motives' of git://trac.sagemath.org/sage into t/23953/iterator_for_hypergeometric_motives

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 6, 2017

Changed commit from 316ab9b to 949a775

@roed314
Copy link
Contributor

roed314 commented Oct 6, 2017

comment:8

Merged in #23671

@vbraun
Copy link
Member

vbraun commented Oct 22, 2017

Changed branch from u/roed/iterator_for_hypergeometric_motives to 949a775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants