Conversion from ZpFM to its fraction field incorrect

[saraedum]

sage: R = ZqFM(2)
sage: K = R.fraction_field()
sage: K(R.zero())
<blankline>

Depends on #23510

CC: @roed314

Component: padics

Author: David Roe

Branch/Commit: b8de189

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/23966

[saraedum]

Branch: u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect

[saraedum]

Changed branch from u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect to none

[saraedum]

comment:2

David, you know this code much better than I do. I have no idea if this is the best fix for this.

[saraedum]

Author: Julian Rüth

[roed314]

Branch: u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect

[roed314]

comment:3

Setting branch back....

---

New commits:

87c900c

normalize() FP elements

[roed314]

Commit: 87c900c

[roed314]

Changed branch from u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect to u/roed/conversion_from_zpfm_to_its_fraction_field_incorrect

[roed314]

Reviewer: Julian Rüth

[roed314]

Changed commit from 87c900c to b8de189

[roed314]

Changed author from Julian Rüth to David Roe

[roed314]

comment:5

Alright, I've taken a different approach, and added in a test.

---

Last 10 new commits:

cb882fd	Update add_bigoh to account for fixed-mod having a fraction field
a826978	Fix _tester_add_bigoh
883e6b5	Fix doctest in local_generic_element.pyx
52cbd2a	Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
bc59ffa	Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field
3292259	Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
dad02c7	Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
189ac2b	Add _test_fraction_field to the coercion tutorial
98d8256	Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into develop
b8de189	Different fix for 23966, add doctest

[roed314]

comment:6

Most of the changes visible are from #23510. This ticket is basically the changes to FP_template.pxi.

[roed314]

Dependencies: #23510

[saraedum]

comment:7

there is one failing doctest from the patchbot which should be unrelated.

[vbraun]

Changed branch from u/roed/conversion_from_zpfm_to_its_fraction_field_incorrect to b8de189