Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler caching in ell_rational_field #23970

Closed
jdemeyer opened this issue Oct 5, 2017 · 9 comments
Closed

Simpler caching in ell_rational_field #23970

jdemeyer opened this issue Oct 5, 2017 · 9 comments
Labels
c: elliptic curves p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

jdemeyer commented Oct 5, 2017

Instead of using a dict to cache results depending on proof, use a tuple (answer, proven). This is easier to understand and results in simpler code. This was already done for __rank in #23962.

Depends on #23962

CC: @koffie

Component: elliptic curves

Author: Jeroen Demeyer

Branch/Commit: 8bce6ff

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23970
@jdemeyer jdemeyer added this to the sage-8.1 milestone Oct 5, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Oct 5, 2017

Dependencies: #23962

@jdemeyer
Copy link
Author

jdemeyer commented Oct 5, 2017

Changed dependencies from #23962 to none

@jdemeyer
Copy link
Author

jdemeyer commented Oct 5, 2017

Branch: u/jdemeyer/simpler_caching_in_ell_rational_field

@jdemeyer
Copy link
Author

jdemeyer commented Oct 5, 2017

New commits:

3cff14crank() of elliptic curves should always consult Cremona database
8bce6ffSimpler caching in ell_rational_field

@jdemeyer
Copy link
Author

jdemeyer commented Oct 5, 2017

Commit: 8bce6ff

@tscrim
Copy link
Collaborator

tscrim commented Oct 5, 2017

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 5, 2017

Reviewer: Travis Scrimshaw

@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2017

Dependencies: #23962

@vbraun
Copy link
Member

vbraun commented Oct 15, 2017

Changed branch from u/jdemeyer/simpler_caching_in_ell_rational_field to 8bce6ff

@vbraun vbraun closed this as completed in 2c6ac6c Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: elliptic curves p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer