New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
giacpy_sage causes doctest failures due to threading #23976
Comments
Author: Jeroen Demeyer |
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:2
So now the default giacsettings.threads is SAGE_NUM_THREADS or 1 if failed to import. Some linear algebra tutorial is added in the libgiac doc and a |
Branch: u/frederichan/giacpy_sage-0.6.6 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reviewer: Jeroen Demeyer |
comment:4
I planned to fix this in the Sage interface, but I guess your fix also works. |
Changed author from Jeroen Demeyer to Frederic Han |
comment:5
Why are you adding that extra doctest in Sage? |
comment:6
I tested the new version of |
comment:7
Replying to @jdemeyer:
Indeed, I though that the doctest was increasing the giacsettings.threads by two and was not restoring it back but it was not the case, I will remove this line. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from u/frederichan/giacpy_sage-0.6.6 to |
Sometimes,
giacpy_sage
doctests can run out of memory. This happens on systems with many cores because too many threads are started. Analogous to #23713, the number of threads should be limited bySAGE_NUM_THREADS
.Updating giacpy_sage to 0.6.6
http://webusers.imj-prg.fr/~frederic.han/xcas/giacpy/sage/giacpy_sage-0.6.6.tar.gz
Modifications details in git:
https://gitlab.math.univ-paris-diderot.fr/han/giacpy-sage
(default max thread, add a setitem method, take account of giac entries in pynac dict for translations from giacpy to sage)
CC: @frederichan-IMJPRG
Component: packages: optional
Author: Frederic Han
Branch/Commit:
dda5551
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/23976
The text was updated successfully, but these errors were encountered: