Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FGP_Modules great again (work over PIDs different from ZZ) #24027

Open
simonbrandhorst opened this issue Oct 13, 2017 · 5 comments
Open

Make FGP_Modules great again (work over PIDs different from ZZ) #24027

simonbrandhorst opened this issue Oct 13, 2017 · 5 comments
Labels
c: linear algebra p: major / 3 t: enhancement

Comments

@simonbrandhorst
Copy link

FGP_Module was written to model finitely generated modules over a principal ideal domain. Currently, only ZZ is tested and works.
This ticket is to make it work for all PIDs

Issues:

  • .denominator() over number fields behaves differently from over ZZ.

Depends on #24031

Component: linear algebra

Branch/Commit: u/sbrandhorst/make_fgp_module_work_over_pids_different_from_zz_ @ b21796b

Issue created by migration from https://trac.sagemath.org/ticket/24027
@simonbrandhorst simonbrandhorst added this to the sage-8.2 milestone Oct 13, 2017
@simonbrandhorst
Copy link
Author

comment:2
sage: from sage.modules.fg_pid.fgp_module import *
sage: L.<w> = NumberField(x^2 - x + 2)
sage:  OL = L.ring_of_integers()
sage: V = OL**3; W = V.span([[0,w,0], [1,0,1-w]], OL)
sage: Q = FGP_Module(V,W)
sage: TestSuite(Q).run()
sage:

Runs now.

@simonbrandhorst
Copy link
Author

Branch: u/sbrandhorst/make_fgp_module_work_over_pids_different_from_zz_

@simonbrandhorst
Copy link
Author

New commits:

b21796bAlternative for ._clear_denom() where it is not defined.

@simonbrandhorst
Copy link
Author

Dependencies: #24031

@simonbrandhorst
Copy link
Author

Commit: b21796b

@simonbrandhorst simonbrandhorst changed the title Make FGP_Module work over PIDs different from ZZ. Make FGP_Modules great again (work over PIDs different from ZZ) Oct 13, 2017
@mkoeppe mkoeppe removed this from the sage-8.2 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkoeppe @simonbrandhorst