Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid _element_constructor in FractionFieldToFunctionField #24033

Closed
jdemeyer opened this issue Oct 13, 2017 · 6 comments
Closed

Avoid _element_constructor in FractionFieldToFunctionField #24033

jdemeyer opened this issue Oct 13, 2017 · 6 comments
Labels
c: coercion p: major / 3 t: enhancement
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

The attribute _element_constructor shouldn't be used: it will eventually be removed. See #23881.

CC: @saraedum @jpflori

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 4f04b16

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/24033
@jdemeyer jdemeyer added this to the sage-8.1 milestone Oct 13, 2017
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/avoid__element_constructor_in_fractionfieldtofunctionfield

@jdemeyer
Copy link
Author

Commit: 4f04b16

@jdemeyer
Copy link
Author

New commits:

4f04b16Avoid _element_constructor in FractionFieldToFunctionField

@roed314
Copy link
Contributor

roed314 commented Oct 13, 2017

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Oct 13, 2017

comment:3

Seems fine to me.

@vbraun
Copy link
Member

vbraun commented Oct 21, 2017

Changed branch from u/jdemeyer/avoid__element_constructor_in_fractionfieldtofunctionfield to 4f04b16

@vbraun vbraun closed this as completed in 20adf60 Oct 21, 2017
@jdemeyer jdemeyer mentioned this issue Oct 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@roed314 @vbraun @jdemeyer