py3 : bad imports and QQ(string)

[fchapoton]

as another step

CC: @tscrim @jhpalmieri @a-andre @kiwifb

Component: python3

Author: Frédéric Chapoton

Branch/Commit: d75000d

Reviewer: Jeroen Demeyer, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/24034

[fchapoton]

Branch: u/chapoton/24034

[fchapoton]

Commit: a6ec385

[fchapoton]

New commits:

a6ec385

py3: some bad imports, and QQ calls on strings

[jdemeyer]

comment:2

What's wrong with QQ(string)? Are we going to disallow that?

[fchapoton]

comment:4

well, this screams (in the experimental python3 build that nobody seems to care about) that bytes is expected and str is given. I am just trying to move forward to more serious issues.

Maybe the call QQ('string') will need to be fixed, but not now and here.

[jdemeyer]

comment:5

Replying to @fchapoton:

well, this screams (in the experimental python3 build that nobody seems to care about)

Then just fix it in your experimental branch instead of an official Sage Trac ticket.

[fchapoton]

comment:6

This I did for sure. But the change is so small that I assumed it would meet no objection.

[jhpalmieri]

comment:8

In lie_algebras/all.py, could we change

from .import examples as lie_algebras

to

from . import examples as lie_algebras

[jhpalmieri]

comment:9

Why don't other instances of QQ(str) fail? There are some for example in rings/rational.pyx.

[jhpalmieri]

comment:10

I don't mind the QQ changes on this ticket, since it is not changing any doctests and not changing any functionality of Sage, just changing how a few rational numbers are initialized in the Sage code.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d75000d

trac 24034 detail

[sagetrac-git]

Changed commit from a6ec385 to d75000d

[fchapoton]

comment:12

Thanks.

This ticket is part of the effort to make sage start when built with python3. It turns out that one of these QQ(string) was sitting on the road. It does not pretend to fix anything else.

Ready to go, if patchbots say green ?

[jhpalmieri]

Reviewer: Jeroen Demeyer, John Palmieri

[vbraun]

Changed branch from u/chapoton/24034 to d75000d