Unify selfdual and self_dual #24048

jm58660 · 2017-10-15T05:25:46Z

This patch will change is_selfdual to is_self_dual in finite posets, so that the naming will be same as in linear codes.

CC: @tscrim

Component: misc

Author: Jori Mäntysalo

Branch/Commit: b3faa90

Reviewer: Travis Scrimshaw, David Roe

Issue created by migration from https://trac.sagemath.org/ticket/24048

The text was updated successfully, but these errors were encountered:

roed314 · 2017-10-25T17:06:41Z

comment:1

I don't know that much about the math involved here, but how are these examples comparable?

tscrim · 2017-10-25T23:04:28Z

comment:2

Jori, is this a matter of code output or method name? If it is the latter, then I would say is_self_dual because otherwise it looks like there is a word "selfdual," which there is not.

jm58660 · 2017-10-26T04:30:07Z

comment:3

Replying to @tscrim:

Jori, is this a matter of code output or method name? If it is the latter, then I would say is_self_dual because otherwise it looks like there is a word "selfdual," which there is not.

Sorry for being unclear. It was the method name I wondered.

I'll make a patch to change the name of function of finite posets.

jm58660 · 2017-10-26T04:39:52Z

Branch: u/jmantysalo/self_dual

roed314 · 2017-10-26T05:15:49Z

comment:5

Oh, I see. I agree that it should be self_dual rather than selfdual.

New commits:

`0d6e5a9`	`selfdual -> self_dual`

roed314 · 2017-10-26T05:15:49Z

Commit: 0d6e5a9

roed314 · 2017-10-26T05:18:34Z

comment:6

I think is_self_dual = deprecated_function_alias(is_selfdual, 24048) should be is_selfdual = deprecated_function_alias(24048, is_self_dual).

tscrim · 2017-10-26T05:19:58Z

comment:7

I would also put the alias declaration below the method declaration (it makes me less worried as a programmer). Once done, and if in a (undeclared) needs review state and doctests pass, positive review.

sagetrac-git · 2017-10-26T05:39:35Z

Branch pushed to git repo; I updated commit sha1. New commits:

`af41159`	`Corrections.`

sagetrac-git · 2017-10-26T05:39:35Z

Changed commit from 0d6e5a9 to af41159

jm58660 · 2017-10-26T05:43:16Z

comment:9

You are both right: I did the deprecation line wrong, and also put it in wrong place.

There was also two places more to change, but now everything should work.

jm58660 · 2017-10-26T05:43:16Z

Author: Jori Mäntysalo

tscrim · 2017-10-26T06:26:08Z

comment:10

Tests pass for me. Positive review.

tscrim · 2017-10-26T06:26:08Z

Reviewer: Travis Scrimshaw, David Roe

kiwifb · 2017-10-31T03:22:47Z

comment:11

Well I believe this test failure originates here

sage -t --long --warn-long 73.3 /usr/lib64/python2.7/site-packages/sage/tests/finite_poset.py
**********************************************************************
File "/usr/lib64/python2.7/site-packages/sage/tests/finite_poset.py", line 144, in sage.tests.finite_poset.test_finite_lattice
Failed example:
    test_finite_lattice(L) is None  # Long time
Expected:
    True
Got:
    doctest:warning
      File "/usr/lib/python-exec/python2.7/sage-runtests", line 103, in <module>
        err = DC.run()
      File "/usr/lib64/python2.7/site-packages/sage/doctest/control.py", line 1093, in run
        self.run_doctests()
      File "/usr/lib64/python2.7/site-packages/sage/doctest/control.py", line 822, in run_doctests
        self.dispatcher.dispatch()
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 1777, in dispatch
        self.parallel_dispatch()
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 1667, in parallel_dispatch
        w.start()  # This might take some time
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 1943, in start
        super(DocTestWorker, self).start()
      File "/usr/lib64/python2.7/multiprocessing/process.py", line 130, in start
        self._popen = Popen(self)
      File "/usr/lib64/python2.7/multiprocessing/forking.py", line 126, in __init__
        code = process_obj._bootstrap()
      File "/usr/lib64/python2.7/multiprocessing/process.py", line 267, in _bootstrap
        self.run()
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 1916, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 2218, in __call__
        result = runner.run(test)
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 663, in run
        return self._run(test, compileflags, out)
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 518, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 888, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.tests.finite_poset.test_finite_lattice[2]>", line 1, in <module>
        test_finite_lattice(L) is None  # Long time
      File "/usr/lib64/python2.7/site-packages/sage/tests/finite_poset.py", line 161, in test_finite_lattice
        P = {x: test_attrcall('is_'+x, L) for x in all_props}
      File "/usr/lib64/python2.7/site-packages/sage/tests/finite_poset.py", line 161, in <dictcomp>
        P = {x: test_attrcall('is_'+x, L) for x in all_props}
      File "/usr/lib64/python2.7/site-packages/sage/tests/finite_poset.py", line 117, in test_attrcall
        return attrcall(name)(L)
      File "/usr/lib64/python2.7/site-packages/sage/misc/misc.py", line 1640, in __call__
        return getattr(x, self.name)(*(self.args+args), **self.kwds)
      File "/usr/lib64/python2.7/site-packages/sage/misc/superseded.py", line 417, in __call__
        "%s is deprecated. Please use %s instead."%(self.__name__, other))
      File "/usr/lib64/python2.7/site-packages/sage/misc/superseded.py", line 101, in deprecation
        warning(trac_number, message, DeprecationWarning, stacklevel)
      File "/usr/lib64/python2.7/site-packages/sage/misc/superseded.py", line 142, in warning
        warn(message, warning_class, stacklevel)
    :
    DeprecationWarning: is_selfdual is deprecated. Please use is_self_dual instead.
    See http://trac.sagemath.org/24048 for details.
    True
**********************************************************************

the warning gets in the way.

tscrim · 2017-10-31T03:52:33Z

comment:12

Indeed it does (also confirmed by the patchbots).

sagetrac-git · 2017-10-31T05:09:19Z

Changed commit from af41159 to b3faa90

sagetrac-git · 2017-10-31T05:09:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b3faa90`	`Correct a test.`

jm58660 · 2017-10-31T05:10:57Z

comment:14

Good catch, my grep did not found that. Corrected.

kiwifb · 2017-10-31T06:33:24Z

comment:15

Replying to @jm58660:

Good catch, my grep did not found that. Corrected.

Yes it passes now.

jm58660 · 2017-10-31T06:40:52Z

comment:16

Thanks!

(English language needs some unification too... ;=) For example "Railway station" -- why not "rail way station" or "railwaystation"? In Finnish it is "rautatieasema".)

vbraun · 2017-10-31T08:05:38Z

comment:17

sage -t --long --warn-long 67.5 src/sage/tests/finite_poset.py
**********************************************************************
File "src/sage/tests/finite_poset.py", line 144, in sage.tests.finite_poset.test_finite_lattice
Failed example:
    test_finite_lattice(L) is None  # Long time
Expected:
    True
Got:
    doctest:warning
      File "/mnt/disk/home/release/Sage/src/bin/sage-runtests", line 125, in <module>
        err = DC.run()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/control.py", line 1144, in run
        self.run_doctests()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/control.py", line 872, in run_doctests
        self.dispatcher.dispatch()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1774, in dispatch
        self.parallel_dispatch()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1664, in parallel_dispatch
        w.start()  # This might take some time
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1940, in start
        super(DocTestWorker, self).start()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/multiprocessing/process.py", line 130, in start
        self._popen = Popen(self)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/multiprocessing/forking.py", line 126, in __init__
        code = process_obj._bootstrap()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/multiprocessing/process.py", line 267, in _bootstrap
        self.run()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1913, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 2215, in __call__
        result = runner.run(test)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 660, in run
        return self._run(test, compileflags, out)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 515, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 885, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.tests.finite_poset.test_finite_lattice[2]>", line 1, in <module>
        test_finite_lattice(L) is None  # Long time
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/tests/finite_poset.py", line 161, in test_finite_lattice
        P = {x: test_attrcall('is_'+x, L) for x in all_props}
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/tests/finite_poset.py", line 161, in <dictcomp>
        P = {x: test_attrcall('is_'+x, L) for x in all_props}
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/tests/finite_poset.py", line 117, in test_attrcall
        return attrcall(name)(L)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/misc.py", line 1640, in __call__
        return getattr(x, self.name)(*(self.args+args), **self.kwds)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/superseded.py", line 417, in __call__
        "%s is deprecated. Please use %s instead."%(self.__name__, other))
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/superseded.py", line 101, in deprecation
        warning(trac_number, message, DeprecationWarning, stacklevel)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/superseded.py", line 142, in warning
        warn(message, warning_class, stacklevel)
    :
    DeprecationWarning: is_selfdual is deprecated. Please use is_self_dual instead.
    See http://trac.sagemath.org/24048 for details.
    True
**********************************************************************
1 item had failures:
   1 of   4 in sage.tests.finite_poset.test_finite_lattice
    [7 tests, 1 failure, 0.83 s]

kiwifb · 2017-10-31T08:07:40Z

comment:18

Replying to @vbraun:

sage -t --long --warn-long 67.5 src/sage/tests/finite_poset.py
**********************************************************************
File "src/sage/tests/finite_poset.py", line 144, in sage.tests.finite_poset.test_finite_lattice
Failed example:
    test_finite_lattice(L) is None  # Long time
Expected:
    True
Got:
    doctest:warning
      File "/mnt/disk/home/release/Sage/src/bin/sage-runtests", line 125, in <module>
        err = DC.run()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/control.py", line 1144, in run
        self.run_doctests()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/control.py", line 872, in run_doctests
        self.dispatcher.dispatch()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1774, in dispatch
        self.parallel_dispatch()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1664, in parallel_dispatch
        w.start()  # This might take some time
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1940, in start
        super(DocTestWorker, self).start()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/multiprocessing/process.py", line 130, in start
        self._popen = Popen(self)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/multiprocessing/forking.py", line 126, in __init__
        code = process_obj._bootstrap()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/multiprocessing/process.py", line 267, in _bootstrap
        self.run()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 1913, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 2215, in __call__
        result = runner.run(test)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 660, in run
        return self._run(test, compileflags, out)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 515, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 885, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.tests.finite_poset.test_finite_lattice[2]>", line 1, in <module>
        test_finite_lattice(L) is None  # Long time
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/tests/finite_poset.py", line 161, in test_finite_lattice
        P = {x: test_attrcall('is_'+x, L) for x in all_props}
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/tests/finite_poset.py", line 161, in <dictcomp>
        P = {x: test_attrcall('is_'+x, L) for x in all_props}
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/tests/finite_poset.py", line 117, in test_attrcall
        return attrcall(name)(L)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/misc.py", line 1640, in __call__
        return getattr(x, self.name)(*(self.args+args), **self.kwds)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/superseded.py", line 417, in __call__
        "%s is deprecated. Please use %s instead."%(self.__name__, other))
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/superseded.py", line 101, in deprecation
        warning(trac_number, message, DeprecationWarning, stacklevel)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/misc/superseded.py", line 142, in warning
        warn(message, warning_class, stacklevel)
    :
    DeprecationWarning: is_selfdual is deprecated. Please use is_self_dual instead.
    See http://trac.sagemath.org/24048 for details.
    True
**********************************************************************
1 item had failures:
   1 of   4 in sage.tests.finite_poset.test_finite_lattice
    [7 tests, 1 failure, 0.83 s]

Already reported and fixed. May be I should have left it in "needs_work" for a bit longer for you to see.

vbraun · 2017-11-02T11:05:40Z

Changed branch from u/jmantysalo/self_dual to b3faa90

jm58660 mannequin added this to the sage-8.1 milestone Oct 15, 2017

jm58660 mannequin added p: minor / 4 labels Oct 15, 2017

This comment has been minimized.

Sign in to view

roed314 added the c: coding theory label Oct 25, 2017

This comment has been minimized.

Sign in to view

jm58660 mannequin added s: needs review and removed c: coding theory labels Oct 26, 2017

tscrim added s: positive review and removed s: needs review labels Oct 26, 2017

tscrim added s: needs work and removed s: positive review labels Oct 31, 2017

jm58660 mannequin added s: needs review and removed s: needs work labels Oct 31, 2017

kiwifb added s: positive review and removed s: needs review labels Oct 31, 2017

vbraun added s: needs work and removed s: positive review labels Oct 31, 2017

kiwifb added s: positive review and removed s: needs work labels Oct 31, 2017

vbraun removed the s: positive review label Nov 2, 2017

vbraun closed this as completed in ca92543 Nov 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify selfdual and self_dual #24048

Unify selfdual and self_dual #24048

jm58660 mannequin commented Oct 15, 2017

This comment has been minimized.

roed314 commented Oct 25, 2017

tscrim commented Oct 25, 2017

jm58660 mannequin commented Oct 26, 2017

jm58660 mannequin commented Oct 26, 2017

roed314 commented Oct 26, 2017

roed314 commented Oct 26, 2017

roed314 commented Oct 26, 2017

tscrim commented Oct 26, 2017

sagetrac-git mannequin commented Oct 26, 2017

sagetrac-git mannequin commented Oct 26, 2017

jm58660 mannequin commented Oct 26, 2017

This comment has been minimized.

jm58660 mannequin commented Oct 26, 2017

tscrim commented Oct 26, 2017

tscrim commented Oct 26, 2017

kiwifb commented Oct 31, 2017

tscrim commented Oct 31, 2017

sagetrac-git mannequin commented Oct 31, 2017

sagetrac-git mannequin commented Oct 31, 2017

jm58660 mannequin commented Oct 31, 2017

kiwifb commented Oct 31, 2017

jm58660 mannequin commented Oct 31, 2017

vbraun commented Oct 31, 2017

kiwifb commented Oct 31, 2017

vbraun commented Nov 2, 2017

Unify selfdual and self_dual #24048

Unify selfdual and self_dual #24048

Comments

jm58660 mannequin commented Oct 15, 2017

This comment has been minimized.

roed314 commented Oct 25, 2017

tscrim commented Oct 25, 2017

jm58660 mannequin commented Oct 26, 2017

jm58660 mannequin commented Oct 26, 2017

roed314 commented Oct 26, 2017

roed314 commented Oct 26, 2017

roed314 commented Oct 26, 2017

tscrim commented Oct 26, 2017

sagetrac-git mannequin commented Oct 26, 2017

sagetrac-git mannequin commented Oct 26, 2017

jm58660 mannequin commented Oct 26, 2017

This comment has been minimized.

jm58660 mannequin commented Oct 26, 2017

tscrim commented Oct 26, 2017

tscrim commented Oct 26, 2017

kiwifb commented Oct 31, 2017

tscrim commented Oct 31, 2017

sagetrac-git mannequin commented Oct 31, 2017

sagetrac-git mannequin commented Oct 31, 2017

jm58660 mannequin commented Oct 31, 2017

kiwifb commented Oct 31, 2017

jm58660 mannequin commented Oct 31, 2017

vbraun commented Oct 31, 2017

kiwifb commented Oct 31, 2017

vbraun commented Nov 2, 2017