Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove imports deprecated in 19879 #24049

Closed
fchapoton opened this issue Oct 15, 2017 · 19 comments
Closed

remove imports deprecated in 19879 #24049

fchapoton opened this issue Oct 15, 2017 · 19 comments

Comments

@fchapoton
Copy link
Contributor

as this helps to enhance the restart under python3

CC: @tscrim @jdemeyer @jhpalmieri @a-andre @kiwifb

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 39ac047

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/24049

@fchapoton fchapoton added this to the sage-8.1 milestone Oct 15, 2017
@fchapoton
Copy link
Contributor Author

New commits:

016cd7aremove import deprecated in 19879

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24049

@fchapoton
Copy link
Contributor Author

Commit: 016cd7a

@jdemeyer
Copy link

comment:2

All the bots are breaking...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Changed commit from 016cd7a to a20b98b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

a20b98bfixing 2 imports

@fchapoton
Copy link
Contributor Author

comment:4

indeed


New commits:

a20b98bfixing 2 imports

@jdemeyer
Copy link

comment:5

Those two imports of binomial are not actually used, so better just remove them. That is also the reason why the deprecation warning did not trigger: with deprecated lazy imports, the warning is only shown when using the functions.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

90ef1deremove one import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Changed commit from a20b98b to 90ef1de

@fchapoton
Copy link
Contributor Author

comment:7

one of them is used, I think. I removed the other one

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

63dc585fixing one import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Changed commit from 90ef1de to 63dc585

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

39ac047remove import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 15, 2017

Changed commit from 63dc585 to 39ac047

@fchapoton
Copy link
Contributor Author

comment:10

green bot, please review

@jdemeyer
Copy link

comment:11

Interestingly, the binomial in src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py is "used" in the code but no doctest tests it (otherwise we would see the deprecation warning). I created #24053 for that.

@vbraun
Copy link
Member

vbraun commented Oct 21, 2017

Changed branch from u/chapoton/24049 to 39ac047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants