Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change some imports of misc #24060

Closed
fchapoton opened this issue Oct 17, 2017 · 24 comments
Closed

change some imports of misc #24060

fchapoton opened this issue Oct 17, 2017 · 24 comments

Comments

@fchapoton
Copy link
Contributor

to avoid some circular imports; that prevent "python -3" to work

Depends on #24055

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 0e4811e

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/24060

@fchapoton fchapoton added this to the sage-8.1 milestone Oct 17, 2017
@fchapoton
Copy link
Contributor Author

New commits:

3eb94e9fixing some imports of misc

@fchapoton
Copy link
Contributor Author

Commit: 3eb94e9

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24060

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

9566e11Merge branch 'u/chapoton/24060' in 8.1.b8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Changed commit from 3eb94e9 to 9566e11

@jdemeyer
Copy link

comment:3

According to the one patchbot, it doesn't apply. But the Trac plugin says that it does.

@jdemeyer
Copy link

comment:4

I assume that the problem is with the patchbot, since the conflicting file (map_reduce.py) is not touched by this ticket.

@fchapoton
Copy link
Contributor Author

comment:5

I just rebased it immediatly after posting,so the patchbot must have taken the bad version

@jdemeyer
Copy link

comment:6

Funny, this one:

bool(misc.mul([x.valuation(p) >= 0 for x in self.ainvs()]))

It shows a particular way of thinking by mathematicians.

This will conflict with #24055.

@jdemeyer
Copy link

Dependencies: #24055

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

639eec1fixing use of forall
9cf9941Merge branch 'u/chapoton/24055' in 8.1.b8
b21b67fMerge branch 'u/chapoton/24060' in 24055

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2017

Changed commit from 9566e11 to b21b67f

@fchapoton
Copy link
Contributor Author

comment:8

I merged the branch with #24055


New commits:

639eec1fixing use of forall
9cf9941Merge branch 'u/chapoton/24055' in 8.1.b8
b21b67fMerge branch 'u/chapoton/24060' in 24055

New commits:

639eec1fixing use of forall
9cf9941Merge branch 'u/chapoton/24055' in 8.1.b8
b21b67fMerge branch 'u/chapoton/24060' in 24055

@jdemeyer
Copy link

comment:9

This is failing on the patchbot...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2017

Changed commit from b21b67f to 0e4811e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

a8cb24aMerge branch 'u/chapoton/24060' in 8.1.b9
0e4811etrac 24060 one step backward

@fchapoton
Copy link
Contributor Author

comment:11

tentative fix, let us see if the patchbots approve


New commits:

a8cb24aMerge branch 'u/chapoton/24060' in 8.1.b9
0e4811etrac 24060 one step backward

New commits:

a8cb24aMerge branch 'u/chapoton/24060' in 8.1.b9
0e4811etrac 24060 one step backward

@jdemeyer
Copy link

comment:12

Do you know what goes wrong in Python 3? Can you post the traceback?

@fchapoton
Copy link
Contributor Author

comment:13

This is not strictly related to python3-build, only to allow the use of "python -3" diagnostic tool with a python2-build.

I once observed something when typing "python -3 src/sage/all.py" in sage-shell. But I cannot manage to reproduce what I remember.

@jdemeyer
Copy link

comment:14

If this is fixing a problem that you cannot reproduce, shouldn't we just close this ticket as invalid?

@fchapoton
Copy link
Contributor Author

comment:15

Well, I would still prefer to have these more specific imports..

@roed314
Copy link
Contributor

roed314 commented Nov 6, 2017

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Nov 6, 2017

comment:16

I think the changes are fine. Jeroen, if you object, feel free to set this back to Needs Work.

@vbraun
Copy link
Member

vbraun commented Dec 11, 2017

Changed branch from u/chapoton/24060 to 0e4811e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants