Fix Cython warnings in finite_rings

[jdemeyer]

Fix all warnings "Compatible but non-identical C method ... not redeclared" and "Overriding cdef method with def method"

This is part of #23600

Component: cython

Author: Jeroen Demeyer

Branch: 9dbd211

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24116

[jdemeyer]

Branch: u/jdemeyer/fix_cython_warnings_in_finite_rings

[jdemeyer]

New commits:

9dbd211

Add abstract `_add_` and `_mul_` methods to FiniteRingElement

[jdemeyer]

Commit: 9dbd211

[tscrim]

comment:5

Can you explain a little bit why you need to explicitly add an _add_ and _mul_ methods to FiniteRingElement? It seems like it is not (suppose to be) a concrete class and we do not do similar declarations in our other abstract subclasses of Element. I'm just trying to understand what is different here.

[jdemeyer]

comment:6

It's a valid question... we do have to add those declarations somewhere and it seemed silly to do it for every finite field element class separately. This abstract base class looked like the correct level of abstraction: it's still rather concrete (vs. Element or RingElement for example). On the other hand: for polynomials, we do add it to every concrete class.

[tscrim]

comment:7

Ah, yea, right. LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:8

Also to anyone else looking at this change, having a doctest here is functionally pointless as these are here mainly as a technical detail. So that it why I positively reviewed this without explicit doctests for those methods.

[vbraun]

Changed branch from u/jdemeyer/fix_cython_warnings_in_finite_rings to 9dbd211

[jdemeyer]

Changed commit from 9dbd211 to none

[jdemeyer]

comment:10

I plan to move this way down to element.pyx in #24607.