Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sympy as docbuild dependency #24238

Closed
dimpase opened this issue Nov 18, 2017 · 11 comments
Closed

add sympy as docbuild dependency #24238

dimpase opened this issue Nov 18, 2017 · 11 comments

Comments

@dimpase
Copy link
Member

dimpase commented Nov 18, 2017

if sympy is not yet built, the docbuilding might fail.
Reported here.

CC: @kiwifb

Component: build

Author: Dima Pasechnik

Branch/Commit: 0c2bbd3

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/24238

@dimpase dimpase added this to the sage-8.1 milestone Nov 18, 2017
@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Nov 18, 2017

Branch: u/dimpase/docbuildsympydep

@dimpase
Copy link
Member Author

dimpase commented Nov 18, 2017

Commit: 0c2bbd3

@dimpase
Copy link
Member Author

dimpase commented Nov 18, 2017

Author: Dima Pasechnik

@kiwifb
Copy link
Member

kiwifb commented Nov 18, 2017

comment:2

Looks good to me. It explains a few messages around the mailing list and is an appropriate fix.

@kiwifb
Copy link
Member

kiwifb commented Nov 18, 2017

Reviewer: François Bissey

@jdemeyer
Copy link

comment:3

I think the fact that the documentation depends on a sympy is a recent regression. I think it might be solved by #24067 which would be a better solution. I'm setting this to sage-pending to check that.

@jdemeyer jdemeyer removed this from the sage-8.1 milestone Nov 19, 2017
@jdemeyer
Copy link

comment:4

In fact, #24067 does fix this ticket in a better way, so I suggest to close this one.

@jdemeyer jdemeyer removed the pending label Nov 19, 2017
@dimpase
Copy link
Member Author

dimpase commented Nov 19, 2017

comment:5

Replying to @jdemeyer:

In fact, #24067 does fix this ticket in a better way, so I suggest to close this one.

I do not get how #24067 would solve the issue on this ticket. sympy is a dependence of docbuilding.

@dimpase dimpase added this to the sage-8.2 milestone Nov 19, 2017
@jdemeyer
Copy link

comment:7

Replying to @dimpase:

sympy is a dependence of docbuilding.

Yes, and that's the bug that #24067 fixes. It shouldn't be a dependency.

Anyway, given that #24067 is stalled, we should merge this anyway. And since it breaks building Sage, it should even be a blocker.

@vbraun
Copy link
Member

vbraun commented Nov 22, 2017

Changed branch from u/dimpase/docbuildsympydep to 0c2bbd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants