Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: do not use mathjax from inside sagenb #24250

Closed
fchapoton opened this issue Nov 20, 2017 · 13 comments
Closed

py3: do not use mathjax from inside sagenb #24250

fchapoton opened this issue Nov 20, 2017 · 13 comments

Comments

@fchapoton
Copy link
Contributor

currently, there is

/home/chapoton/sage3/src/doc/common/conf.py in <module>()
    221 
    222     from pkg_resources import Requirement, working_set
--> 223     sagenb_path = working_set.find(Requirement.parse('sagenb')).location
    224     mathjax_relative = os.path.join('sagenb','data','mathjax')
    225 
AttributeError: 'NoneType' object has no attribute 'location'

This error happens in a python3-built-sage, where sagenb is not installed.

Component: documentation

Author: Frédéric Chapoton

Branch: 8a6e110

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/24250

@fchapoton fchapoton added this to the sage-8.1 milestone Nov 20, 2017
@fchapoton

This comment has been minimized.

@jdemeyer
Copy link

comment:2

Should be easy since mathjax is a Sage package now.

@fchapoton
Copy link
Contributor Author

comment:3

ok, but where to find the mathjax directory ?

EDIT : Found it, in sage/local/share/mathjax/

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24250

@fchapoton
Copy link
Contributor Author

New commits:

8a6e110py 24250 mathjax without sagenb

@fchapoton
Copy link
Contributor Author

Commit: 8a6e110

@fchapoton
Copy link
Contributor Author

comment:5

green bot, please review

@jhpalmieri
Copy link
Member

Author: Frédéric Chapoton

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:6

The changes make sense. I'm changing the milestone to 8.2: this is not crucial for the 8.1 release.

@vbraun
Copy link
Member

vbraun commented Dec 13, 2017

Changed branch from u/chapoton/24250 to 8a6e110

@embray
Copy link
Contributor

embray commented Dec 15, 2017

Changed commit from 8a6e110 to none

@embray
Copy link
Contributor

embray commented Dec 15, 2017

comment:8

Ah, thanks for fixing this. I didn't find it before since it wasn't in the "python3" component, but this should save some hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants