Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MPFR, MPC and MPFI #24353

Closed
jdemeyer opened this issue Dec 9, 2017 · 40 comments
Closed

Upgrade MPFR, MPC and MPFI #24353

jdemeyer opened this issue Dec 9, 2017 · 40 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 9, 2017

Tarballs:

CC: @zimmermann6 @kiwifb

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 3c089ff

Reviewer: Paul Zimmermann

Issue created by migration from https://trac.sagemath.org/ticket/24353

@jdemeyer jdemeyer added this to the sage-8.2 milestone Dec 9, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2017

Branch: u/jdemeyer/upgrade_to_mpfr_4_0_0

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2017

comment:3

As reported on the MPFR mailing list by other people, this breaks MPC:

/bin/bash ../libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..   -I/usr/local/src/sage-config/local/include -I/usr/local/src/sage-config/local/
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/usr/local/src/sage-config/local/include -I/usr/local/src/sage-config/local/include -m64 -O2 -march=corei7-
mul.c:179:1: error: conflicting types for 'mpfr_fmma'
 mpfr_fmma (mpfr_ptr z, mpfr_srcptr a, mpfr_srcptr b, mpfr_srcptr c,
 ^
In file included from mpc.h:25:0,
                 from mpc-impl.h:30,
                 from mul.c:22:
../../../../../../../include/mpfr.h:731:6: note: previous declaration of 'mpfr_fmma' was here
 __MPFR_DECLSPEC int mpfr_fmma (mpfr_ptr, mpfr_srcptr, mpfr_srcptr, mpfr_srcptr,
      ^
Makefile:532: recipe for target 'mul.lo' failed
make[6]: *** [mul.lo] Error 1

New commits:

f93f4acUpgrade to MPFR 4.0.0

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2017

Commit: f93f4ac

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer jdemeyer changed the title Upgrade to MPFR 4.0.0 Upgrade to MPFR 4.0.0 and MPC 1.1.0 Dec 14, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 14, 2017

Changed commit from f93f4ac to 4db514d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 14, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4db514dUpgrade to MPFR 4.0.0 and MPC 1.1.0

@jdemeyer
Copy link
Author

Upstream: Reported upstream. No feedback yet.

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Upgrade to MPFR 4.0.0 and MPC 1.1.0 Upgrade MPFR, MPC and MPFI Dec 15, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@zimmermann6
Copy link

comment:9

Unfortunately, it seems that MPFI is a dead project

Fabrice Rouillier tells me he is preparing the release of MPFI 1.5.2. Stay tuned!

@jdemeyer
Copy link
Author

jdemeyer commented Jan 8, 2018

comment:10

Replying to @zimmermann6:

Fabrice Rouillier tells me he is preparing the release of MPFI 1.5.2. Stay tuned!

Is this personal communication or is this on some public channel? In the latter case, do you have a link?

@zimmermann6
Copy link

comment:11

Is this personal communication or is this on some public channel?

it is personal communication. If/when I have some information about a release candidate,
I will post it here.

@zimmermann6
Copy link

comment:12

MPFI 1.5.2 is available from https://gforge.inria.fr/frs/?group_id=157

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 8, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

16e3180Upgrade MPFR, MPC and MPFI

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 8, 2018

Changed commit from 4db514d to 16e3180

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 8, 2018

Changed commit from 16e3180 to 092ac74

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 8, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

092ac74Upgrade MPFR, MPC and MPFI

@jdemeyer
Copy link
Author

jdemeyer commented Jan 8, 2018

comment:16

There are a few obvious doctest failures in src/sage/rings/real_mpfr.pyx. All should be easy to fix.

@zimmermann6
Copy link

comment:17

I am curious to know which failures you get.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2018

Changed commit from 092ac74 to afc3b66

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

afc3b66Minor fixes for MPFR-4; support MPFR_RNDF

@jdemeyer
Copy link
Author

jdemeyer commented Jan 9, 2018

comment:19

I added a few fixes in the last commit. With this, all tests pass. So, this ticket is technically needs_review, modulo the fact that there is no MPC release yet...

@zimmermann6
Copy link

comment:20

in the last commit:

faithful rounding (currently experimental; not supported for every operation)

"not supported for every operation" is not correct: it is supported, but not guaranteed correct for every operation.

Apart from that, I am ok with this commit.

We expect to release MPC 1.1 this week or next week.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2018

Changed commit from afc3b66 to 19646be

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

19646beMinor fixes for MPFR-4; support MPFR_RNDF

@jdemeyer
Copy link
Author

jdemeyer commented Jan 9, 2018

Reviewer: Paul Zimmermann

@jdemeyer
Copy link
Author

jdemeyer commented Jan 9, 2018

comment:22

Replying to @zimmermann6:

"not supported for every operation" is not correct: it is supported, but not guaranteed correct for every operation.

Fixed.

Apart from that, I am ok with this commit.

OK, I'm adding you as reviewer.

@zimmermann6
Copy link

comment:23

MPC 1.1.0 is now available from https://ftp.gnu.org/gnu/mpc

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2018

Changed commit from 19646be to 3c089ff

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

84e3a8aUpgrade MPFR, MPC and MPFI
3c089ffMinor fixes for MPFR-4; support MPFR_RNDF

@videlec
Copy link
Contributor

videlec commented Jan 12, 2018

comment:27

all tests pass on quasar (ubuntu x86_64)

@jdemeyer
Copy link
Author

Changed upstream from Reported upstream. No feedback yet. to none

@zimmermann6
Copy link

comment:29

I did:

$ git co u/jdemeyer/upgrade_to_mpfr_4_0_0
$ git pull
$ make build

and got an error:

ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagepad.org/spkg/upstream/mp
fr/mpfr-4.0.0.tar.bz2'
Traceback (most recent call last):
  File "/tmp/sage/build/bin/sage-download-file", line 28, in <module>
    run_safe()
  File "/tmp/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 118, in
 run_safe
    run()
  File "/tmp/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 100, in
 run
    app.download_tarball(args.url_or_tarball, args.destination)
  File "/tmp/sage/build/bin/../sage_bootstrap/download/app.py", line 43, in down
load_tarball
    tarball.download()
  File "/tmp/sage/build/bin/../sage_bootstrap/tarball.py", line 161, in download
    raise FileNotMirroredError('tarball does not exist on mirror network')
sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror ne
twork
************************************************************************
Error downloading mpfr-4.0.0.tar.bz2

@jdemeyer
Copy link
Author

comment:30

You need to manually download the 3 tarballs mentioned on this ticket and put them in the upstream directory in your Sage installation.

@zimmermann6
Copy link

comment:31

modulo the fact that the patchbot is happy, I give a positive review.

@vbraun
Copy link
Member

vbraun commented Jan 18, 2018

Changed branch from u/jdemeyer/upgrade_to_mpfr_4_0_0 to 3c089ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants