upgrade arb to 2.12.0 #24369

sagetrac-tmonteil · 2017-12-11T18:45:21Z

arb fails to pass self-tests on x86_64 skylake. This is fixed in arb 2.12.0.

(The new version fails to pass self-tests on my 32bit VM, while it did not before, see #24661.)

tarball here: https://github.com/fredrik-johansson/arb/archive/2.12.0.tar.gz

Upstream: Fixed upstream, in a later stable release.

CC: @fredrik-johansson @kiwifb

Component: packages: standard

Keywords: sdl

Author: Dima Pasechnik

Branch: c793138

Reviewer: Thierry Monteil, Marc Mezzarobba, Fredrik Johansson

Issue created by migration from https://trac.sagemath.org/ticket/24369

The text was updated successfully, but these errors were encountered:

sagetrac-tmonteil · 2017-12-11T18:55:32Z

comment:1

Attachment: arb-2.11.1.p0.log

sagetrac-tmonteil · 2017-12-11T18:55:32Z

Upstream: Reported upstream. No feedback yet.

fredrik-johansson · 2017-12-11T20:08:33Z

comment:2

Does upgrading to 2.12 solve the issue?

dimpase · 2017-12-11T23:05:49Z

comment:3

By the way, the same error on x86_64 (a skylake CPU, Linux)

[arb-2.11.1.p0] gauss_period_minpoly....make[3]: *** [../Makefile.subdirs:84: 
../build/arb_fmpz_poly/test/t-gauss_period_minpoly_RUN] Floating point exception

I'll investigate the upgrade option...

dimpase · 2017-12-12T00:02:43Z

Author: Dima Pasechnik

dimpase · 2017-12-12T00:02:43Z

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

dimpase · 2017-12-12T00:02:43Z

Commit: c793138

dimpase · 2017-12-12T00:02:43Z

comment:4

mildly tested on x86_64, fixed numerical noise (which almost uniformly went down :-)).

New commits:

`c793138`	`update arb to 2.12.0, doctest fixes, and #24369`

dimpase · 2017-12-12T00:02:43Z

Branch: u/dimpase/arb212

kiwifb · 2017-12-29T09:04:51Z

comment:6

Not a good time for me. I won't be able to give you a review before the 3rd or 4rth of January.

sagetrac-tmonteil · 2017-12-30T01:19:59Z

comment:7

With 2.12.0, i still have one test failure on 32bit system:

l_vec_hurwitz....
 L value differ
L(1/2, 1) single = (0 + 0j)  +/-  (0, 0j)
L(1/2, 1) multi = (-0.30909754859579756426 + 0j)  +/-  (2.54e-23, 0j)

(-0.3090975486 + 0j)  +/-  (2.54e-23, 0j)
(0.7888523833 - 0.1836680212j)  +/-  (2.02e-23, 1.54e-23j)
(0.4432168971 - 0.236477911j)  +/-  (1.99e-23, 1.32e-23j)
(1.648021942 + 0.03777565741j)  +/-  (1.55e-23, 8.22e-24j)
(0.6185977148 + 0.146695673j)  +/-  (2.08e-23, 1.32e-23j)
(0.5039871966 - 0.8215955013j)  +/-  (2.02e-23, 1.71e-23j)
(0.750432146 + 0j)  +/-  (2.54e-23, 0j)
(0.5039871966 + 0.8215955013j)  +/-  (2.02e-23, 1.71e-23j)
(0.6185977148 - 0.146695673j)  +/-  (2.08e-23, 1.32e-23j)
(1.648021942 - 0.03777565741j)  +/-  (1.55e-23, 8.22e-24j)
(0.4432168971 + 0.236477911j)  +/-  (1.99e-23, 1.32e-23j)
(0.7888523833 + 0.1836680212j)  +/-  (2.02e-23, 1.54e-23j)


../Makefile.subdirs:84: recipe for target '../build/acb_dirichlet/test/t-l_vec_hurwitz_RUN' failed

See also the attached log.

sagetrac-tmonteil · 2017-12-30T01:19:59Z

Reviewer: Thierry Monteil

dimpase · 2018-01-20T12:13:30Z

comment:8

Attachment: arb-2.12.0.p0.log

while I can confirm that this is reproducible on a "real" x86 (arando buildbot)

[arb-2.12.0.p0] l_vec_hurwitz....
[arb-2.12.0.p0]  L value differ
[arb-2.12.0.p0] L(1/2, 1) single = (0 + 0j)  +/-  (0, 0j)
[arb-2.12.0.p0] L(1/2, 1) multi = (-0.30909754859579756426 + 0j)  +/-  (2.54e-23, 0j)
[arb-2.12.0.p0]
[arb-2.12.0.p0] (-0.3090975486 + 0j)  +/-  (2.54e-23, 0j)
[arb-2.12.0.p0] (0.7888523833 - 0.1836680212j)  +/-  (2.02e-23, 1.54e-23j)
[arb-2.12.0.p0] (0.4432168971 - 0.236477911j)  +/-  (1.99e-23, 1.32e-23j)
[arb-2.12.0.p0] (1.648021942 + 0.03777565741j)  +/-  (1.55e-23, 8.22e-24j)
[arb-2.12.0.p0] (0.6185977148 + 0.146695673j)  +/-  (2.08e-23, 1.32e-23j)
[arb-2.12.0.p0] (0.5039871966 - 0.8215955013j)  +/-  (2.02e-23, 1.71e-23j)
[arb-2.12.0.p0] (0.750432146 + 0j)  +/-  (2.54e-23, 0j)
[arb-2.12.0.p0] (0.5039871966 + 0.8215955013j)  +/-  (2.02e-23, 1.71e-23j)
[arb-2.12.0.p0] (0.6185977148 - 0.146695673j)  +/-  (2.08e-23, 1.32e-23j)
[arb-2.12.0.p0] (1.648021942 - 0.03777565741j)  +/-  (1.55e-23, 8.22e-24j)
[arb-2.12.0.p0] (0.4432168971 + 0.236477911j)  +/-  (1.99e-23, 1.32e-23j)
[arb-2.12.0.p0] (0.7888523833 + 0.1836680212j)  +/-  (2.02e-23, 1.54e-23j)
[arb-2.12.0.p0]
[arb-2.12.0.p0]
[arb-2.12.0.p0] make[3]: *** [../build/acb_dirichlet/test/t-l_vec_hurwitz_RUN] Aborted (core dumped)

I still insist that we should upgrade, as the previous version also does not pass all the self-tests, albeit on a different (and much more popular) platform, x86_64 (if it is skylake- it seems to work OK on nechalem).

See the attached log.

dimpase · 2018-01-20T12:17:03Z

Attachment: arb-2.11.1.p0.2.log

failure on skylake

kiwifb · 2018-01-23T02:01:11Z

comment:10

Just to make sure, your commit remove the whole of src/sage/rings/complex_arb.pyx but not the corresponding pxd file? are you sure?

dimpase · 2018-01-23T08:25:48Z

comment:11

Replying to @kiwifb:

Just to make sure, your commit remove the whole of src/sage/rings/complex_arb.pyx but not the corresponding pxd file? are you sure?

this is a trac git viewer bug. If you look at the commit in comment 4, it would make sense.

kiwifb · 2018-01-23T08:27:55Z

comment:12

Replying to @dimpase:

Replying to @kiwifb:

Just to make sure, your commit remove the whole of src/sage/rings/complex_arb.pyx but not the corresponding pxd file? are you sure?

this is a trac git viewer bug. If you look at the commit in comment 4, it would make sense.

Nope, commit in comment 4 looks just the same.

dimpase · 2018-01-23T09:11:10Z

comment:13

Huh?
sagemath/sagetrac-mirror@c793138

(it could be it is different for you). To be sure, use git,
or look here:
https://github.com/sagemath/sagetrac-mirror/compare/u/dimpase/arb212

dimpase · 2018-01-23T09:12:20Z

comment:14

This is how it looks to me:


author	Dima Pasechnik <dimpase@gmail.com>	2017-12-11 23:58:06 +0000
committer	Dima Pasechnik <dimpase@gmail.com>	2017-12-11 23:58:06 +0000
commit	c79313811851584c5b6732ea12da8b40d04b0377 (patch)
tree	94c8774bc96b6b9e5386f9e5502ee60db3de0eb2
parent	Updated SageMath version to 8.1 (diff)
update arb to 2.12.0, doctest fixes, and #24369u/dimpase/arb212
Diffstat
-rw-r--r--	build/pkgs/arb/checksums.ini	6	
-rw-r--r--	build/pkgs/arb/package-version.txt	2	
-rw-r--r--	src/sage/rings/complex_arb.pyx	14	
-rw-r--r--	src/sage/rings/real_arb.pyx	4	
4 files changed, 13 insertions, 13 deletions
diff --git a/build/pkgs/arb/checksums.ini b/build/pkgs/arb/checksums.ini
index 78909d5..1924ee0 100644
--- a/build/pkgs/arb/checksums.ini
+++ b/build/pkgs/arb/checksums.ini
@@ -1,4 +1,4 @@
 tarball=arb-VERSION.tar.gz
-sha1=2f06bfb433cdaecde0e824c5e638094fd666a0d1
-md5=d63cdd1147104790826c93bc8651104f
-cksum=2745482665
+sha1=27476d0529e48a07d92da90bd0fb80dd18f443e3
+md5=733285d9705d10b8024e551ffa81952f
+cksum=2391183744
diff --git a/build/pkgs/arb/package-version.txt b/build/pkgs/arb/package-version.txt
index 99993ff..c8810e9 100644
--- a/build/pkgs/arb/package-version.txt
+++ b/build/pkgs/arb/package-version.txt
@@ -1 +1 @@
-2.11.1.p0
+2.12.0.p0
diff --git a/src/sage/rings/complex_arb.pyx b/src/sage/rings/complex_arb.pyx
index ee048fb..71fad24 100644
--- a/src/sage/rings/complex_arb.pyx
+++ b/src/sage/rings/complex_arb.pyx
@@ -2603,7 +2603,7 @@ cdef class ComplexBall(RingElement):
         EXAMPLES::
 
             sage: CBF(0, -1).agm1()
-            [0.5990701173678 +/- 1.15e-14] + [-0.5990701173678 +/- 1.19e-14]*I
+            [0.599070117367796 +/- 3.9...e-16] + [-0.599070117367796 +/- 5.5...e-16]*I
         """
         cdef ComplexBall res = self._new()
         if _do_sig(prec(self)): sig_on()
@@ -3318,9 +3318,9 @@ cdef class ComplexBall(RingElement):
              [0.002473055794309 +/- 5.01e-16] + [0.003859554040267 +/- 4.45e-16]*I,
              [-0.01299087561709 +/- 4.72e-15] + [0.00725027521915 +/- 4.32e-15]*I]
             sage: (z + 3 + 4*tau).elliptic_p(tau, 3)
-            [[-3.2892099677271 +/- 2.29e-14] + [-0.00036737673029 +/- 8.58e-15]*I,
-             [0.002473055794 +/- 6.59e-13] + [0.003859554040 +/- 6.17e-13]*I,
-             [-0.0129908756 +/- 3.39e-11] + [0.0072502752 +/- 3.60e-11]*I]
+            [[-3.28920996772709 +/- 8.4...e-15] + [-0.00036737673029 +/- 4.1...e-15]*I,
+             [0.0024730557943 +/- 6.6...e-14] + [0.0038595540403 +/- 8.8...e-14]*I,
+             [-0.01299087562 +/- 5.6...e-12] + [0.00725027522 +/- 3.5...e-12]*I]
 
         """
         cdef ComplexBall my_tau = self._parent.coerce(tau)
@@ -3356,7 +3356,7 @@ cdef class ComplexBall(RingElement):
         EXAMPLES::
 
             sage: CBF(2,3).elliptic_k()
-            [1.0429132919285 +/- 3.65e-14] + [0.6296824723086 +/- 6.15e-14]*I
+            [1.04291329192852 +/- 5.9...e-15] + [0.62968247230864 +/- 3.4...e-15]*I
 
         """
         cdef ComplexBall result = self._new()
@@ -3373,7 +3373,7 @@ cdef class ComplexBall(RingElement):
         EXAMPLES::
 
             sage: CBF(2,3).elliptic_e()
-            [1.472797144959 +/- 4.82e-13] + [-1.231604783936 +/- 1.25e-13]*I
+            [1.472797144959 +/- 4.5...e-13] + [-1.231604783936 +/- 9.5...e-14]*I
 
         """
         cdef ComplexBall result = self._new()
@@ -3520,7 +3520,7 @@ cdef class ComplexBall(RingElement):
         EXAMPLES::
 
             sage: CBF(1/2).legendre_P(5)
-            0.08984375000000000
+            [0.08984375000000000 +/- 4.5...e-18]
             sage: CBF(1,2).legendre_P(CBF(2,3), CBF(0,1))
             [0.10996180744364 +/- 7.45e-15] + [0.14312767804055 +/- 8.38e-15]*I
             sage: CBF(-10).legendre_P(5, 325/100)
diff --git a/src/sage/rings/real_arb.pyx b/src/sage/rings/real_arb.pyx
index aa12ae0..9aad425 100644
--- a/src/sage/rings/real_arb.pyx
+++ b/src/sage/rings/real_arb.pyx
@@ -3451,7 +3451,7 @@ cdef class RealBall(RingElement):
             sage: RBF(1/2).polylog(1)
             [0.6931471805599 +/- 5.02e-14]
             sage: RBF(1/3).polylog(1/2)
-            [0.44210883528067 +/- 6.75e-15]
+            [0.44210883528067 +/- 6.7...e-15]
             sage: RBF(1/3).polylog(RLF(pi))
             [0.34728895057225 +/- 5.51e-15]
 
@@ -3551,7 +3551,7 @@ cdef class RealBall(RingElement):
             sage: RBF(1).agm(1)
             1.000000000000000
             sage: RBF(sqrt(2)).agm(1)^(-1)
-            [0.83462684167407 +/- 4.31e-15]
+            [0.83462684167407 +/- 3.9...e-15]
         """
         cdef RealBall other_as_ball
         cdef RealBall res = self._new()

kiwifb · 2018-01-23T09:13:42Z

comment:15

Oh yes that's right. I did something wrong there.

kiwifb · 2018-02-01T20:55:58Z

comment:16

I was going to give this a positive review but re-reading things I am getting concerned that the new arbś tests fail systematically on 32bits machine. Is it a correct assertion?

sagetrac-tmonteil · 2018-02-01T21:14:27Z

comment:17

Replying to @kiwifb:

I was going to give this a positive review but re-reading things I am getting concerned that the new arbś tests fail systematically on 32bits machine. Is it a correct assertion?

Yes. I am OK to either open another ticket for the upgrade, or another for the 32bit issue, but in any case, please do not just close that one without opening another ticket, since the issue is not solved (or only partially).

dimpase · 2018-02-01T22:39:36Z

comment:18

This upgrade is an improvement. Surely the 32-bit issue is not fully solved (the new bug is in new code as far as I can see), but this should go to a followup ticket.

fredrik-johansson · 2018-02-02T09:11:20Z

comment:19

Yes, the 32-bit bug is almost certainly in new code and should not be a concern for Sage.

dimpase · 2018-02-05T17:49:22Z

comment:20

The follow-up ticket is here: #24661

Let us finally be done with this one.

mezzarobba · 2018-02-07T16:51:21Z

Changed reviewer from Thierry Monteil to Thierry Monteil, Marc Mezzarobba, Fredrik Johansson

vbraun · 2018-02-09T23:48:07Z

Changed branch from u/dimpase/arb212 to c793138

Konrad127123 · 2018-02-15T23:25:13Z

comment:23

This ticket has been closed, but as far as I can see, it's not been merged into the develop branch. Is that intentional?

Apologies if I'm missing something obvious.

(Edit: I don't know why trac says I deleted the commit.)

Konrad127123 · 2018-02-15T23:25:13Z

Changed commit from c793138 to none

dimpase · 2018-02-15T23:46:19Z

comment:24

Replying to @Konrad127123:

This ticket has been closed, but as far as I can see, it's not been merged into the develop branch. Is that intentional?

Apologies if I'm missing something obvious.

I think it will be in the next beta (it has been merged in a sort of trunk, and this happened later than the latest ticket in the current beta(5))

(Edit: I don't know why trac says I deleted the commit.)

this is just a quirk of the interface.
In fact the branch u/dimpase/arb212 is still there if you need it, e.g.
from the mirror:

https://github.com/sagemath/sagetrac-mirror/tree/u/dimpase/arb212

sagetrac-tmonteil · 2019-08-27T19:45:19Z

Changed keywords from none to sdl

sagetrac-tmonteil mannequin added this to the sage-8.2 milestone Dec 11, 2017

sagetrac-tmonteil mannequin added c: packages: standard labels Dec 11, 2017

This comment has been minimized.

Sign in to view

dimpase added the s: needs review label Dec 12, 2017

sagetrac-tmonteil mannequin added s: needs work and removed s: needs review labels Dec 30, 2017

This comment has been minimized.

Sign in to view

dimpase added s: needs review and removed s: needs work labels Jan 20, 2018

This comment has been minimized.

Sign in to view

mezzarobba changed the title ~~arb fails to pass self-tests~~ upgrade arb to 2.12.0 Feb 7, 2018

mezzarobba added s: positive review and removed s: needs review labels Feb 7, 2018

vbraun removed the s: positive review label Feb 9, 2018

vbraun closed this as completed in 66f944c Feb 9, 2018

dimpase mentioned this issue Aug 28, 2019

fix arb problems on 32-bit systems #24661

Closed

mezzarobba mentioned this issue Feb 20, 2018

Integration of piecewise analytic complex functions using arb #24686

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade arb to 2.12.0 #24369

upgrade arb to 2.12.0 #24369

sagetrac-tmonteil mannequin commented Dec 11, 2017

sagetrac-tmonteil mannequin commented Dec 11, 2017

sagetrac-tmonteil mannequin commented Dec 11, 2017

fredrik-johansson commented Dec 11, 2017

dimpase commented Dec 11, 2017

dimpase commented Dec 12, 2017

dimpase commented Dec 12, 2017

This comment has been minimized.

dimpase commented Dec 12, 2017

dimpase commented Dec 12, 2017

dimpase commented Dec 12, 2017

kiwifb commented Dec 29, 2017

sagetrac-tmonteil mannequin commented Dec 30, 2017

sagetrac-tmonteil mannequin commented Dec 30, 2017

dimpase commented Jan 20, 2018

dimpase commented Jan 20, 2018

This comment has been minimized.

kiwifb commented Jan 23, 2018

dimpase commented Jan 23, 2018

kiwifb commented Jan 23, 2018

dimpase commented Jan 23, 2018

dimpase commented Jan 23, 2018

kiwifb commented Jan 23, 2018

kiwifb commented Feb 1, 2018

sagetrac-tmonteil mannequin commented Feb 1, 2018

dimpase commented Feb 1, 2018

fredrik-johansson commented Feb 2, 2018

dimpase commented Feb 5, 2018

mezzarobba commented Feb 7, 2018

This comment has been minimized.

vbraun commented Feb 9, 2018

Konrad127123 commented Feb 15, 2018

Konrad127123 commented Feb 15, 2018

dimpase commented Feb 15, 2018

sagetrac-tmonteil mannequin commented Aug 27, 2019

upgrade arb to 2.12.0 #24369

upgrade arb to 2.12.0 #24369

Comments

sagetrac-tmonteil mannequin commented Dec 11, 2017

sagetrac-tmonteil mannequin commented Dec 11, 2017

sagetrac-tmonteil mannequin commented Dec 11, 2017

fredrik-johansson commented Dec 11, 2017

dimpase commented Dec 11, 2017

dimpase commented Dec 12, 2017

dimpase commented Dec 12, 2017

This comment has been minimized.

dimpase commented Dec 12, 2017

dimpase commented Dec 12, 2017

dimpase commented Dec 12, 2017

kiwifb commented Dec 29, 2017

sagetrac-tmonteil mannequin commented Dec 30, 2017

sagetrac-tmonteil mannequin commented Dec 30, 2017

dimpase commented Jan 20, 2018

dimpase commented Jan 20, 2018

This comment has been minimized.

kiwifb commented Jan 23, 2018

dimpase commented Jan 23, 2018

kiwifb commented Jan 23, 2018

dimpase commented Jan 23, 2018

dimpase commented Jan 23, 2018

kiwifb commented Jan 23, 2018

kiwifb commented Feb 1, 2018

sagetrac-tmonteil mannequin commented Feb 1, 2018

dimpase commented Feb 1, 2018

fredrik-johansson commented Feb 2, 2018

dimpase commented Feb 5, 2018

mezzarobba commented Feb 7, 2018

This comment has been minimized.

vbraun commented Feb 9, 2018

Konrad127123 commented Feb 15, 2018

Konrad127123 commented Feb 15, 2018

dimpase commented Feb 15, 2018

sagetrac-tmonteil mannequin commented Aug 27, 2019