Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Parent method _convert_method_map #24381

Closed
jdemeyer opened this issue Dec 15, 2017 · 20 comments
Closed

New Parent method _convert_method_map #24381

jdemeyer opened this issue Dec 15, 2017 · 20 comments

Comments

@jdemeyer
Copy link

Factor out the logic to determine a NamedConvertMap in _generic_convert_map. This way, it can be used by _coerce_map_from_ methods.

Also clean up the logic in discover_coerce_map_from a bit and remove the unused force_use flag from DefaultConvertMap and NamedConvertMap.

CC: @videlec @tscrim

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 18d9877

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24381

@jdemeyer jdemeyer added this to the sage-8.2 milestone Dec 15, 2017
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

Commit: cf2f643

@jdemeyer
Copy link
Author

New commits:

cf2f643New Parent method _convert_method_map

@jdemeyer jdemeyer changed the title New Parent method _convert_method_map _convert_method_name should take priority as conversion Dec 15, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title _convert_method_name should take priority as conversion Always use special methods for conversion/coercion if possible Dec 19, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Always use special methods for conversion/coercion if possible New Parent method _convert_method_map Dec 19, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Dependencies: #24372

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

375e40fMap._extra_slots(): do not pass dict
6f46f29New Parent method _convert_method_map

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2017

Changed commit from cf2f643 to 6f46f29

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5c2f4f5New Parent method _convert_method_map

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2017

Changed commit from 6f46f29 to 5c2f4f5

@jdemeyer
Copy link
Author

Changed dependencies from #24372 to none

@jdemeyer
Copy link
Author

comment:14

Ping? This is a dependency of #24371

@tscrim
Copy link
Collaborator

tscrim commented Jan 30, 2018

comment:15

Incredibly nitpicking thing:

+from . coerce_maps cimport (NamedConvertMap, DefaultConvertMap,
+        DefaultConvertMap_unique, CallableConvertMap)

The space after the . looks strange, but I guess that is not a syntax error (a bit to my surprise). Feel free to set a positive review if you don't care or on my behalf if tweaked.

@tscrim
Copy link
Collaborator

tscrim commented Jan 30, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2018

Changed commit from 5c2f4f5 to 18d9877

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

18d9877Fix cimport

@jdemeyer
Copy link
Author

comment:17

Thanks!

@vbraun
Copy link
Member

vbraun commented Feb 2, 2018

Changed branch from u/jdemeyer/new_parent_method__convert_method_map to 18d9877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants