New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Parent method _convert_method_map #24381
Comments
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dependencies: #24372 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed dependencies from #24372 to none |
comment:14
Ping? This is a dependency of #24371 |
comment:15
Incredibly nitpicking thing: +from . coerce_maps cimport (NamedConvertMap, DefaultConvertMap,
+ DefaultConvertMap_unique, CallableConvertMap) The space after the |
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:17
Thanks! |
Changed branch from u/jdemeyer/new_parent_method__convert_method_map to |
Factor out the logic to determine a
NamedConvertMap
in_generic_convert_map
. This way, it can be used by_coerce_map_from_
methods.Also clean up the logic in
discover_coerce_map_from
a bit and remove the unusedforce_use
flag fromDefaultConvertMap
andNamedConvertMap
.CC: @videlec @tscrim
Component: coercion
Author: Jeroen Demeyer
Branch/Commit:
18d9877
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/24381
The text was updated successfully, but these errors were encountered: