New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix is_interval() on graphs #24446
Comments
Commit: |
New commits:
|
Author: Jori Mäntysalo |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Three lines to code, several to docs. Easy to review. I changed this test:
I think it is not a good test, even if it is good way to generate interval graphs. |
comment:6
Some comments You should
you may remove some
|
Reviewer: David Coudert |
comment:7
Replying to @dcoudert:
Of 21 Wikipedia links on the doc page only one, I will do other changes. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
What' wrong with my links? References seems to be broken. (Patch contains a non-related colon in |
comment:10
It should be I'm always having difficulties with links to methods. Here the last 2 don't turn to links in the html doc. Don't know why. |
comment:11
Replying to @dcoudert:
I tried that too, no help. Frédéric, what's wrong with my links? |
comment:12
Sorry, I have no idea either, and I usually don't build the doc. |
comment:13
This form is working for me !!!
If you follow the links, you may discover another issue: in the html file |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Thanks David! I mark this as needs_review, because I think that the case for Wikipedia links should be handled for all functions, if at all. |
comment:16
This looks good to me. |
Changed branch from u/jmantysalo/fix_is_interval___on_graphs to |
Unify
certificate=True
: in every function return a pair where first element is a Boolean.Also add definition of interval graph and a link to Wikipedia page.
CC: @dcoudert @kevindilks @fchapoton
Component: graph theory
Author: Jori Mäntysalo
Branch/Commit:
98782ab
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/24446
The text was updated successfully, but these errors were encountered: