Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZZ is complete #24464

Closed
videlec opened this issue Jan 3, 2018 · 10 comments
Closed

ZZ is complete #24464

videlec opened this issue Jan 3, 2018 · 10 comments
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-8.2

Comments

@videlec
Copy link
Contributor

videlec commented Jan 3, 2018 

sage: ZZ.completion(Infinity,53)
Real Field with 53 bits of precision

CC: @tscrim

Component: algebra

Author: Vincent Delecroix

Branch/Commit: c0b49bb

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24464
@videlec videlec added this to the sage-8.2 milestone Jan 3, 2018
@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

New commits:

c0b49bb24464: ZZ is complete

@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

Commit: c0b49bb

@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

Branch: u/vdelecroix/24464

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2018

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2018

Reviewer: Travis Scrimshaw

@videlec
Copy link
Contributor Author

videlec commented Jan 4, 2018

comment:3

doctest failure

@videlec
Copy link
Contributor Author

videlec commented Jan 4, 2018

comment:4

appears to be on #24456... let the patchbot run a full testsuite

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2018

comment:5

It (essentially) came back clean.

@vbraun
Copy link
Member

vbraun commented Jan 5, 2018

Changed branch from u/vdelecroix/24464 to c0b49bb

@vbraun vbraun closed this as completed in 1f32f89 Jan 5, 2018
@videlec videlec mentioned this issue Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @videlec