Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the completion functor prints the precision #24465

Closed
videlec opened this issue Jan 3, 2018 · 14 comments
Closed

Let the completion functor prints the precision #24465

videlec opened this issue Jan 3, 2018 · 14 comments

Comments

@videlec
Copy link
Contributor

videlec commented Jan 3, 2018

sage: RR.construction()
(Completion[+Infinity], Rational Field)

will become

sage: RR.construction()
(Completion[+Infinity, prec=53], Rational Field)

CC: @tscrim

Component: categories

Author: Vincent Delecroix

Branch/Commit: c474002

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24465

@videlec videlec added this to the sage-8.2 milestone Jan 3, 2018
@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

Commit: 5fbafc6

@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

New commits:

5fbafc624456: let completion functor prints precision

@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Jan 3, 2018

Branch: u/vdelecroix/24465

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2018

comment:2

LGTM.

@videlec
Copy link
Contributor Author

videlec commented Jan 4, 2018

comment:3

doctest failure

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2018

Changed commit from 5fbafc6 to c474002

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c47400224465: fix doctest

@videlec
Copy link
Contributor Author

videlec commented Jan 4, 2018

comment:5

Let the patchbot pass first.

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2018

comment:6

Patchbot (morally) comes back clean.

@vbraun
Copy link
Member

vbraun commented Jan 4, 2018

comment:7
File "src/doc/en/reference/coercion/index.rst", line 627, in doc.en.reference.coercion.index
Failed example:
    sage.categories.pushout.construction_tower(Frac(CDF['x']))
Expected:
    [(None,
     Fraction Field of Univariate Polynomial Ring in x over Complex Double Field),
    (FractionField, Univariate Polynomial Ring in x over Complex Double Field),
    (Poly[x], Complex Double Field),
    (AlgebraicClosureFunctor, Real Double Field),
    (Completion[+Infinity], Rational Field),
    (FractionField, Integer Ring)]
Got:
    [(None,
      Fraction Field of Univariate Polynomial Ring in x over Complex Double Field),
     (FractionField, Univariate Polynomial Ring in x over Complex Double Field),
     (Poly[x], Complex Double Field),
     (AlgebraicClosureFunctor, Real Double Field),
     (Completion[+Infinity, prec=53], Rational Field),
     (FractionField, Integer Ring)]
**********************************************************************
1 item had failures:
   1 of  99 in doc.en.reference.coercion.index
    [84 tests, 1 failure, 3.38 s]

@tscrim
Copy link
Collaborator

tscrim commented Jan 5, 2018

comment:8

It looks like this does not have c474002. Can you give it another go Volker?

@vbraun
Copy link
Member

vbraun commented Jan 6, 2018

Changed branch from u/vdelecroix/24465 to c474002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants