Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pynac-0.7.15 #24497

Closed
rwst opened this issue Jan 9, 2018 · 25 comments
Closed

Upgrade to pynac-0.7.15 #24497

rwst opened this issue Jan 9, 2018 · 25 comments

Comments

@rwst
Copy link

rwst commented Jan 9, 2018

In 0.7.15:

https://github.com/pynac/pynac/releases/download/pynac-0.7.15/pynac-0.7.15.tar.bz2

CC: @kiwifb

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: d085587

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/24497

@rwst rwst added this to the sage-8.2 milestone Jan 9, 2018
@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Jan 9, 2018

Branch: u/rws/upgrade_to_pynac_0_7_15

@rwst
Copy link
Author

rwst commented Jan 9, 2018

Commit: 880ebf3

@rwst
Copy link
Author

rwst commented Jan 9, 2018

New commits:

907aff624497: pkg version/chksum
880ebf324497: doctest fixes

@rwst
Copy link
Author

rwst commented Jan 9, 2018

Author: Ralf Stephan

@videlec
Copy link
Contributor

videlec commented Jan 9, 2018

comment:5

All tests pass on quasar.

@tscrim
Copy link
Collaborator

tscrim commented Jan 9, 2018

comment:6

The only thing I'm not sure about is the change in modular/modform_hecketriangle/graded_ring_element.py. Can you explain the rationale?

@rwst
Copy link
Author

rwst commented Jan 9, 2018

comment:7

The former result changes quite a bit, I think because small changes are enlarged by substitution into a polynomial. I tried to preserve the assumed spirit of the test, i.e. a nonzero real part of the result, but to make it more robust. Of course I may be wrong with my assumptions.

@jdemeyer
Copy link

jdemeyer commented Jan 9, 2018

comment:8

Passes tests on sardonis (ppc64le) too.

@jdemeyer
Copy link

@jdemeyer
Copy link

Changed commit from 880ebf3 to 70275ab

@jdemeyer
Copy link

comment:10

Replying to @rwst:

The former result changes quite a bit, I think because small changes are enlarged by substitution into a polynomial. I tried to preserve the assumed spirit of the test, i.e. a nonzero real part of the result, but to make it more robust. Of course I may be wrong with my assumptions.

I kept the test but adjusted the answer. Does that work for you?


New commits:

70275ab24497: doctest fixes

@rwst
Copy link
Author

rwst commented Jan 12, 2018

comment:11

Replying to @jdemeyer:

I kept the test but adjusted the answer. Does that work for you?

Yes.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@rwst
Copy link
Author

rwst commented Jan 12, 2018

comment:13

Thanks for the review.

@vbraun
Copy link
Member

vbraun commented Jan 14, 2018

comment:14

On Ubuntu 16 32-bit:

**********************************************************************
File "src/sage/modular/modform_hecketriangle/graded_ring_element.py", line 1947, in sage.modular.modform_hecketriangle.graded_ring_element.?.evaluate
Failed example:
    f_i(i + 1e-1000)  # rel tol 1e-3
Expected:
    -5.96189764223709e-14 - 4.10147008296517e-1000*I
Got:
    -6.08402217494586e-14 - 4.10147008296517e-1000*I
Tolerance exceeded in 1 of 2:
    -5.96189764223709e-14 vs -6.08402217494586e-14, tolerance 2e-02 > 1e-03
**********************************************************************
1 item had failures:
   1 of 132 in sage.modular.modform_hecketriangle.graded_ring_element.?.evaluate
    [671 tests, 1 failure, 40.96 s]

@rwst
Copy link
Author

rwst commented Jan 15, 2018

comment:15

So you see how useless the test is in this form. I'm replacing it with my version.

@rwst
Copy link
Author

rwst commented Jan 15, 2018

Changed branch from u/jdemeyer/upgrade_to_pynac_0_7_15 to u/rws/24497

@rwst
Copy link
Author

rwst commented Jan 15, 2018

Changed commit from 70275ab to 7754ab0

@rwst
Copy link
Author

rwst commented Jan 15, 2018

comment:17

It's just a test.


New commits:

7754ab024497: doctest fixes

@jdemeyer
Copy link

comment:18

Replying to @rwst:

So you see how useless the test is in this form. I'm replacing it with my version.

Not useless. We just need to increase the tolerance.

@rwst
Copy link
Author

rwst commented Jan 15, 2018

Changed branch from u/rws/24497 to u/rws/24497-1

@rwst
Copy link
Author

rwst commented Jan 15, 2018

Changed commit from 7754ab0 to d085587

@rwst
Copy link
Author

rwst commented Jan 15, 2018

New commits:

d08558724497: doctest fixes

@vbraun
Copy link
Member

vbraun commented Jan 18, 2018

Changed branch from u/rws/24497-1 to d085587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants