Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Africa map graph #24538

Closed
jm58660 mannequin opened this issue Jan 14, 2018 · 9 comments
Closed

Add Africa map graph #24538

jm58660 mannequin opened this issue Jan 14, 2018 · 9 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jan 14, 2018

This patch adds the map of Africa. Also changes center() as an example of how we could use this kind of graphs.

CC: @dcoudert

Component: graph theory

Author: Jori Mäntysalo

Branch/Commit: 53e2802

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/24538
@jm58660 jm58660 mannequin added this to the sage-8.2 milestone Jan 14, 2018
@jm58660 jm58660 mannequin added c: graph theory labels Jan 14, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 18, 2018

Branch: u/jmantysalo/add_africa_map_graph

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 18, 2018

comment:2

Untested.

New commits:

d97ef5aAdd the map of Africa.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 18, 2018

Commit: d97ef5a

@jm58660

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

53e2802Link function to right place.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2018

Changed commit from d97ef5a to 53e2802

@jm58660 jm58660 mannequin added the s: needs review label Jan 18, 2018
@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:5

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Jan 20, 2018

Changed branch from u/jmantysalo/add_africa_map_graph to 53e2802

@vbraun vbraun closed this as completed in 269c401 Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
2 participants
@vbraun @dcoudert