Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legendre_P() a GinacFunction #24553

Closed
rwst opened this issue Jan 16, 2018 · 14 comments
Closed

Make legendre_P() a GinacFunction #24553

rwst opened this issue Jan 16, 2018 · 14 comments

Comments

@rwst
Copy link

rwst commented Jan 16, 2018

Pynac-0.7.16 offers legendre_P(). The performance increase:

                            Python+Pari        Pynac
                            -----------        -----
sage: _=legendre_P(10,x)      510 µs           29 µs
sage: _=legendre_P(100,x)     2.3 ms           290 µs
sage: _=legendre_P(1000,x)    28 ms            3.5 ms
sage: _=legendre_P(10000,x)   1.1 s            110 ms
sage: _=legendre_P(50000,x)   30 s             2.1 s

overall a speedup of a comfortable order of magnitude.

Depends on #24668

Component: performance

Author: Ralf Stephan

Branch/Commit: 6c0ef30

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24553

@rwst rwst added this to the sage-8.2 milestone Jan 16, 2018
@rwst
Copy link
Author

rwst commented Jan 16, 2018

@rwst
Copy link
Author

rwst commented Jan 16, 2018

New commits:

6c0ef3024553: Make legendre_P() a GinacFunction

@rwst
Copy link
Author

rwst commented Jan 16, 2018

Commit: 6c0ef30

@rwst

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jan 16, 2018

comment:3

Ready for review?

@rwst
Copy link
Author

rwst commented Jan 17, 2018

Dependencies: pynac-0.7.16

@rwst
Copy link
Author

rwst commented Jan 17, 2018

comment:4

It will not work without pynac-0.7.16.

@rwst
Copy link
Author

rwst commented Feb 19, 2018

Changed dependencies from pynac-0.7.16 to #24668

@rwst
Copy link
Author

rwst commented Feb 19, 2018

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Mar 4, 2018

comment:6

Replying to @tscrim:

Ready for review?

Yes, please.

@tscrim
Copy link
Collaborator

tscrim commented Mar 4, 2018

comment:7

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 4, 2018

Reviewer: Travis Scrimshaw

@rwst
Copy link
Author

rwst commented Mar 5, 2018

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 5, 2018

Changed branch from u/rws/make_legendre_p___a_ginacfunction to 6c0ef30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants