Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: using the new tags py3 and py2 in some rst files #24570

Closed
fchapoton opened this issue Jan 19, 2018 · 11 comments
Closed

py3: using the new tags py3 and py2 in some rst files #24570

fchapoton opened this issue Jan 19, 2018 · 11 comments

Comments

@fchapoton
Copy link
Contributor

replacing the former "optional - py2" used there.

CC: @jdemeyer @tscrim @kiwifb @embray

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 1aa0545

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/24570

@fchapoton fchapoton added this to the sage-8.2 milestone Jan 19, 2018
@fchapoton
Copy link
Contributor Author

Commit: 1aa0545

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24570

@fchapoton
Copy link
Contributor Author

New commits:

1aa0545py3: using the new tags py2 and py3 in the rst files

@embray
Copy link
Contributor

embray commented Jan 19, 2018

comment:2

I wonder if we can somehow make the documentation builder actually omit the #py2 or #py3 lines depending on which python the docs are being built against. Or if that's even really desirable.

@fchapoton
Copy link
Contributor Author

comment:3

Erik, this is a bit frustrating that you alone have a branch where you can launch doctests in python3.

How far are we from having vanilla sage build and start with python3 ? I think after #24223, we will be very close but not quite there. In my opinion, we should aim to reach that state as soon as possible. And the next step would be to be able to use "sage -t" in vanilla sage+py3.

@fchapoton
Copy link
Contributor Author

comment:4

bot is morally green

@fchapoton
Copy link
Contributor Author

comment:5

ping ?

@embray
Copy link
Contributor

embray commented Jan 22, 2018

comment:6

Replying to @fchapoton:

Erik, this is a bit frustrating that you alone have a branch where you can launch doctests in python3.

I don't think that's true. I'm sure I've pointed you to #24343 which has the fixes necessary for the doctest runner to work, at least I think. You can always merge that in to your local branch and try it--I'd assumed you already have been.

@fchapoton
Copy link
Contributor Author

comment:7

could please somebody review this very easy ticket ?

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Jan 27, 2018

Changed branch from u/chapoton/24570 to 1aa0545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants