Cython vtable warnings in padics

[jdemeyer]

warning: sage/rings/padics/CR_template.pxi:779:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:1396:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/FP_template.pxi:1096:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'FPElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:779:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/CR_template.pxi:1396:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'CRElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/FP_template.pxi:1096:10: Compatible but non-identical C method 'val_unit' not redeclared in definition part of extension type 'FPElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/padic_generic_element.pyx:279:10: Compatible but non-identical C method '_floordiv_' not redeclared in definition part of extension type 'pAdicGenericElement'.  This may cause incorrect vtables to be generated.
warning: sage/rings/padics/padic_generic_element.pyx:390:10: Compatible but non-identical C method '_mod_' not redeclared in definition part of extension type 'pAdicGenericElement'.  This may cause incorrect vtables to be generated.

This is part of #23600.

CC: @roed314

Component: padics

Keywords: padicIMA

Work Issues: rename right to other; add p parameter to val_unit everywhere

Author: Julian Rüth

Branch/Commit: u/saraedum/24609 @ a0bac48

Issue created by migration from https://trac.sagemath.org/ticket/24609

[roed314]

Changed keywords from none to padicIMA

[saraedum]

Author: Julian Rüth

[saraedum]

Branch: u/saraedum/24609

[saraedum]

Work Issues: is the patchbot happy?

[saraedum]

Commit: a0bac48

[saraedum]

New commits:

a0bac48

Fixes Cython warnings

[saraedum]

comment:6

I have not tested this, but the warnings are gone.

[jdemeyer]

comment:7

Minor nitpick, but could you use self, other instead of self, right?

[saraedum]

comment:8

The implementation uses right. So I should change all the implementations as well I guess?

[jdemeyer]

comment:9

I don't care so much. Whatever you feel like.

[saraedum]

Changed work issues from is the patchbot happy? to rename right to other; add p parameter to val_unit everywhere