New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move permutation groups to new coercion model #24612
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
Aha! So, the problem is that Sage thinks there is a coercion from the group to the subgroup, and not only from the subgroup to the group? That would indeed explain the current behaviour (multiplying a group element with a subgroup element works, multiplying a subgroup element by a group element doesn't work). |
comment:3
Permutation groups still use the old coercion model. So moving to the new coercion model (unfortunately a non-trivial operation) is almost certainly going to fix this. |
Commit: |
Author: Travis Scrimshaw |
New commits:
|
Changed keywords from coercion subgroup to coercion subgroup, days94 |
New commits:
|
comment:8
Why this in
All tests in |
Reviewer: Jeroen Demeyer |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
That is to support the old "coercions" as conversions that were previously supported. I don't think such a thing was explicitly tested, but I wanted to mitigate the number of behavioral changes. |
Changed branch from public/coercion/perm_groups_new_parent-24612 to |
We have
This is very wrong, there is no coercion from
S4
toG
:Component: coercion
Keywords: coercion subgroup, days94
Author: Travis Scrimshaw
Branch/Commit:
05ae254
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/24612
The text was updated successfully, but these errors were encountered: