Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and documentation improvements with hyperbolic functions #24649

Closed
rwst opened this issue Feb 3, 2018 · 16 comments
Closed

Clean up and documentation improvements with hyperbolic functions #24649

rwst opened this issue Feb 3, 2018 · 16 comments

Comments

@rwst
Copy link

rwst commented Feb 3, 2018

The class HyperbolicFunction is superfluous and the docs need a nice header with index and examples. Let's also remove the usage of arcxxx from all doctests in this file. The printed names arcxxx will need a separate ticket to change. Also latexification needs to be fixed.

Depends on #24668

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 4eef487

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24649

@rwst rwst added this to the sage-8.2 milestone Feb 3, 2018
@rwst

This comment has been minimized.

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Feb 4, 2018

comment:3

The printed name directly depends on the name= keyword in the function initialization which itself must match a set_name call inside Pynac. The best way to proceed, instead of accompanying a new Pynac release with a sizeable doctest patch, would be to add a separate (small) Pynac patch to a ticket, either this or separate, depending on reviewer's convenience.

@rwst
Copy link
Author

rwst commented Feb 4, 2018

comment:4

There was also a bug that mapped acsch to SymPy's asech.

@rwst
Copy link
Author

rwst commented Feb 4, 2018

@rwst
Copy link
Author

rwst commented Feb 4, 2018

New commits:

2ad47a124649: Clean up and documentation improvements with hyperbolic functions

@rwst
Copy link
Author

rwst commented Feb 4, 2018

Commit: 2ad47a1

@rwst
Copy link
Author

rwst commented Feb 4, 2018

Author: Ralf Stephan

@tscrim
Copy link
Collaborator

tscrim commented Feb 4, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 4, 2018

comment:7

LGTM.

@rwst
Copy link
Author

rwst commented Feb 5, 2018

comment:8

Thanks!

@rwst
Copy link
Author

rwst commented Feb 7, 2018

@rwst
Copy link
Author

rwst commented Feb 7, 2018

New commits:

f5b3de424668: version/chzksum
67f9ddc24668: doctest fixes
4eef48724649: Clean up and documentation improvements with hyperbolic functions

@rwst
Copy link
Author

rwst commented Feb 7, 2018

Changed commit from 2ad47a1 to 4eef487

@rwst
Copy link
Author

rwst commented Feb 7, 2018

Dependencies: #24668

@vbraun
Copy link
Member

vbraun commented Feb 15, 2018

Changed branch from u/rws/24649 to 4eef487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants