Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in type E bijection from cythonizing RiggedPartition #24656

Closed
tscrim opened this issue Feb 4, 2018 · 7 comments
Closed

Fix bug in type E bijection from cythonizing RiggedPartition #24656

tscrim opened this issue Feb 4, 2018 · 7 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Feb 4, 2018

RiggedPartition.insert_cell now has a signature of an int, so it can no longer take float("inf") to add a cell to the largest row. This was not caught on #24175 because the test was not sufficient. So we also change the test.

Depends on #24175

CC: @sagetrac-sage-combinat @anneschilling @bsalisbury1

Component: combinatorics

Keywords: rigged configurations

Author: Travis Scrimshaw

Branch: 516935c

Reviewer: Ben Salisbury

Issue created by migration from https://trac.sagemath.org/ticket/24656

@tscrim tscrim added this to the sage-8.2 milestone Feb 4, 2018
@tscrim
Copy link
Collaborator Author

tscrim commented Feb 4, 2018

Dependencies: #24175

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 4, 2018

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 4, 2018

Commit: 516935c

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 4, 2018

New commits:

82bc1fbInitial optimization to avoid polytopes for small number of possible choices.
65df5a1Faster _calc_vacancy_number and phi. Cythonized RiggedPartition.
f715a8eMerge branch 'public/combinat/optimize_rc_generation-24175' of git://trac.sagemath.org/sage into public/combinat/fix_type_E_bijection-TBA
516935cFixing bug in type E RC bijection and added a better test.

@bsalisbury1
Copy link

Reviewer: Ben Salisbury

@vbraun
Copy link
Member

vbraun commented Feb 9, 2018

Changed branch from public/combinat/fix_type_E_bijection-24656 to 516935c

@fchapoton
Copy link
Contributor

Changed commit from 516935c to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants